-
Notifications
You must be signed in to change notification settings - Fork 882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for aggregator type in DataDog metric provider #3293
feat: Add support for aggregator type in DataDog metric provider #3293
Conversation
cc: @meeech and @zachaller since both of you seem to be involved in getting DataDog API v2 functionality out :) |
Go Published Test Results2 097 tests 2 097 ✅ 2m 49s ⏱️ Results for commit 68cf420. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3293 +/- ##
==========================================
+ Coverage 81.82% 81.83% +0.01%
==========================================
Files 135 135
Lines 20633 20636 +3
==========================================
+ Hits 16882 16888 +6
+ Misses 2880 2877 -3
Partials 871 871 ☔ View full report in Codecov by Sentry. |
E2E Tests Published Test Results 4 files 4 suites 3h 28m 30s ⏱️ For more details on these failures, see this check. Results for commit 68cf420. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @NaurisSadovskis
thanks for this. Looks good overall. See my 2 comments. feel free to reach out on slack if you have any q's
@NaurisSadovskis One other thing I forgot - please have a look at the docs and update those to explain using this new option. |
b3de059
to
8c4ad82
Compare
Is this ready for a final review? |
@zachaller @meeech - yes, this is ready for final review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NaurisSadovskis Thanks again for doing this pr. Sorry about the delay on getting back to it.
Looks 👍🏼
One minor nit fix in the docs, but otherwise good to go
Signed-off-by: Nauris <nauris.sadovskis@wave.com>
Signed-off-by: Nauris <nauris.sadovskis@wave.com>
Signed-off-by: Nauris <nauris.sadovskis@wave.com>
Signed-off-by: Nauris <nauris.sadovskis@wave.com>
Signed-off-by: Nauris <nauris.sadovskis@wave.com>
Signed-off-by: Nauris <nauris.sadovskis@wave.com>
Signed-off-by: Nauris <nauris.sadovskis@wave.com>
Co-authored-by: mitchell amihod <mitchell@amihod.com> Signed-off-by: Nauris <nauris.sadovskis@wave.com>
c2cab30
to
8c9b882
Compare
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 1 New issue |
Thank you for the contribution! |
This pull request adds ability to override default DataDog (v2) API aggregator (
last
) for metrics-based queries [docs].We stumbled upon this issue when using count-based distributed metrics and
moving_rollup()
function which aggregates data points in a given time period [docs]:Querying this data via DataDog API (and a formula
b
) reported the last value as17.0
:Switching aggregator from
last
tosum
behaves as expected.Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.