Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ability to run only the analysis controller #3336

Merged
merged 2 commits into from
Feb 3, 2024

Conversation

gdsoumya
Copy link
Member

@gdsoumya gdsoumya commented Jan 29, 2024

This PR introduces the ability to run only the AnalysisRun controller, without needing the Rollout and Experiment CRDs to be installed in the cluster. This allows users/projects to adopt Argo Rollouts for the analysis piece alone.

Usage:

./rollouts-controller --controller=analysis

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@gdsoumya gdsoumya requested a review from jessesuen January 29, 2024 11:28
Copy link
Contributor

github-actions bot commented Jan 29, 2024

Go Published Test Results

2 097 tests   2 097 ✅  2m 49s ⏱️
  118 suites      0 💤
    1 files        0 ❌

Results for commit 661807f.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 29, 2024

E2E Tests Published Test Results

  4 files    4 suites   3h 30m 25s ⏱️
106 tests  96 ✅  6 💤  4 ❌
442 runs  398 ✅ 24 💤 20 ❌

For more details on these failures, see this check.

Results for commit 661807f.

♻️ This comment has been updated with latest results.

@gdsoumya gdsoumya force-pushed the feat/only_analysis_ctrl branch from d19494a to 7dad2d7 Compare January 29, 2024 12:31
Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
@gdsoumya gdsoumya force-pushed the feat/only_analysis_ctrl branch from 7dad2d7 to cf26d73 Compare January 29, 2024 12:56
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 82 lines in your changes are missing coverage. Please review.

Comparison is base (5e5314b) 81.77% compared to head (661807f) 81.53%.

Files Patch % Lines
controller/controller.go 20.83% 72 Missing and 4 partials ⚠️
utils/record/record.go 40.00% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3336      +/-   ##
==========================================
- Coverage   81.77%   81.53%   -0.25%     
==========================================
  Files         135      135              
  Lines       20649    20726      +77     
==========================================
+ Hits        16886    16898      +12     
- Misses       2888     2952      +64     
- Partials      875      876       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

4 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jessesuen jessesuen changed the title feat: allow running only analysis controller feat: support ability to run only the analysis controller Jan 29, 2024
Copy link
Member

@jessesuen jessesuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would like @zachaller to sign off.

@zachaller
Copy link
Collaborator

LGTM, this opens up some interesting use cases.

@zachaller zachaller merged commit 7258fe7 into argoproj:master Feb 3, 2024
24 of 26 checks passed
@gdsoumya gdsoumya self-assigned this Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants