-
Notifications
You must be signed in to change notification settings - Fork 882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support ability to run only the analysis controller #3336
Conversation
Go Published Test Results2 097 tests 2 097 ✅ 2m 49s ⏱️ Results for commit 661807f. ♻️ This comment has been updated with latest results. |
E2E Tests Published Test Results 4 files 4 suites 3h 30m 25s ⏱️ For more details on these failures, see this check. Results for commit 661807f. ♻️ This comment has been updated with latest results. |
d19494a
to
7dad2d7
Compare
Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
7dad2d7
to
cf26d73
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3336 +/- ##
==========================================
- Coverage 81.77% 81.53% -0.25%
==========================================
Files 135 135
Lines 20649 20726 +77
==========================================
+ Hits 16886 16898 +12
- Misses 2888 2952 +64
- Partials 875 876 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 4 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but would like @zachaller to sign off.
LGTM, this opens up some interesting use cases. |
This PR introduces the ability to run only the AnalysisRun controller, without needing the Rollout and Experiment CRDs to be installed in the cluster. This allows users/projects to adopt Argo Rollouts for the analysis piece alone.
Usage:
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.