Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not require pod readiness when switching desired service selector on abort #3338

Merged
merged 5 commits into from
Feb 5, 2024
Merged

fix: do not require pod readiness when switching desired service selector on abort #3338

merged 5 commits into from
Feb 5, 2024

Conversation

zachaller
Copy link
Collaborator

No description provided.

@zachaller
do not switch service selectors back when using alb due to race betwe…
c5f4254 
…en two controllers with pod readiness gates

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
@codecov Codecov
Copy link

codecov bot commented Jan 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c492b06) 81.82% compared to head (38ab9c6) 82.86%.
Report is 4 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3338      +/-   ##
==========================================
+ Coverage   81.82%   82.86%   +1.04%     
==========================================
  Files         135      135              
  Lines       20688    16841    -3847     
==========================================
- Hits        16928    13956    -2972     
+ Misses       2886     2010     -876     
- Partials      874      875       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 30, 2024 •
edited
Loading

Go Published Test Results

2 106 tests   2 106 ✅  2m 50s ⏱️
  118 suites      0 💤
    1 files        0 ❌

Results for commit 38ab9c6.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 30, 2024 •
edited
Loading

E2E Tests Published Test Results

  4 files    4 suites   3h 25m 24s ⏱️
106 tests  97 ✅  6 💤 3 ❌
428 runs  400 ✅ 24 💤 4 ❌

For more details on these failures, see this check.

Results for commit 38ab9c6.

♻️ This comment has been updated with latest results.

@zachaller
update tests for alb
aca715a 
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
@zachaller
lets not check for readiness instead
1ed3dbe 
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
@zachaller zachaller changed the title fix: do not switch service selectors on canary/desired when using ALB fix: do not require pod readiness when switching desired service selector on abort Feb 1, 2024
@zachaller
clean up notes
cb3e7c4 
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
@zachaller
fix /
38ab9c6 
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
8.4% Duplication on New Code

See analysis details on SonarCloud

@zachaller zachaller marked this pull request as ready for review February 5, 2024 18:55
leoluz
leoluz approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachaller zachaller merged commit f165763 into argoproj:master Feb 5, 2024
23 checks passed
zachaller added a commit that referenced this pull request Feb 5, 2024
@zachaller
fix: do not require pod readiness when switching desired service sele…
041e68f 
…ctor on abort (#3338)

* do not switch service selectors back when using alb due to race between two controllers with pod readiness gates

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* update tests for alb

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* lets not check for readiness instead

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* clean up notes

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* fix /

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

---------

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoluz leoluz leoluz approved these changes

Assignees
No one assigned
Labels
cherry-pick/release-1.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zachaller @leoluz