fix(controller): treat spec.canary.analysis.template empty list as spec.canary.analysis not set

[kevinqian-db]

Partially addresses #3441

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
• The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
• I've signed my commits with DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My builds are green. Try syncing with master if they are not.
• My organization is added to USERS.md.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
8.0% Duplication on New Code

See analysis details on SonarCloud

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.92%. Comparing base (8405f2e) to head (a6c76a2).
Report is 41 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3446      +/-   ##
==========================================
+ Coverage   81.83%   82.92%   +1.08%     
==========================================
  Files         135      135              
  Lines       20688    16922    -3766     
==========================================
- Hits        16931    14032    -2899     
+ Misses       2883     2012     -871     
- Partials      874      878       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Go Published Test Results

2 138 tests   2 138 ✅  2m 51s ⏱️
  119 suites      0 💤
    1 files        0 ❌

Results for commit a6c76a2.

[github-actions]

E2E Tests Published Test Results

  4 files    4 suites   3h 48m 42s ⏱️
108 tests  96 ✅  6 💤 6 ❌
438 runs  408 ✅ 24 💤 6 ❌

For more details on these failures, see this check.

Results for commit a6c76a2.

[zachaller]

Thanks for the fix!