Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show more information in the UI about why Rollout gets aborted #3957

Open
andrii-korotkov-verkada opened this issue Nov 19, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@andrii-korotkov-verkada

Summary

Provide more information in status and events about rollout abort before steps with analysis runs.

Use Cases

Right now if the failure happened on the step before analysis run is configured to happen, there might be no indication what went wrong, e.g. no bad events and generic message in status like

- lastTransitionTime: '2024-11-19T21:48:19Z'
  lastUpdateTime: '2024-11-19T21:48:19Z'
  message: Rollout aborted update to revision 386
  reason: RolloutAborted
  status: 'False'
  type: Progressing

The info+ logs weren't helpful either.


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

@andrii-korotkov-verkada
Copy link
Author

Here's the relevant code in Rollouts:

	if isAborted {
		revision, _ := replicasetutil.Revision(c.rollout)
		message := fmt.Sprintf(conditions.RolloutAbortedMessage, revision)
		if c.pauseContext.abortMessage != "" {
			message = fmt.Sprintf("%s: %s", message, c.pauseContext.abortMessage)
		}
		condition := conditions.NewRolloutCondition(v1alpha1.RolloutProgressing, corev1.ConditionFalse, conditions.RolloutAbortedReason, message)
		if conditions.SetRolloutCondition(&newStatus, *condition) {
			c.recorder.Warnf(c.rollout, record.EventOptions{EventReason: conditions.RolloutAbortedReason}, message)
		}
	}

So looks like abortMessage can be missing sometimes.
@zachaller, do you know why we won't always have some abort message?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant