From b560ad383d3a7227964c4e4a30e7b69ce6bc9b03 Mon Sep 17 00:00:00 2001 From: Anton Gilgur <4970083+agilgur5@users.noreply.github.com> Date: Sun, 9 Jun 2024 14:57:45 -0400 Subject: [PATCH] chore!: remove duplicate Server env vars, plus `--basehref` -> `--base-href` (#12653) Signed-off-by: Anton Gilgur --- cmd/argo/commands/client/conn.go | 2 +- cmd/argo/commands/root.go | 2 +- cmd/argo/commands/server.go | 15 ++------------- docs/argo-server.md | 6 +++--- docs/cli/argo.md | 4 ++-- docs/cli/argo_archive.md | 2 +- docs/cli/argo_archive_delete.md | 2 +- docs/cli/argo_archive_get.md | 2 +- docs/cli/argo_archive_list-label-keys.md | 2 +- docs/cli/argo_archive_list-label-values.md | 2 +- docs/cli/argo_archive_list.md | 2 +- docs/cli/argo_archive_resubmit.md | 2 +- docs/cli/argo_archive_retry.md | 2 +- docs/cli/argo_auth.md | 2 +- docs/cli/argo_auth_token.md | 2 +- docs/cli/argo_cluster-template.md | 2 +- docs/cli/argo_cluster-template_create.md | 2 +- docs/cli/argo_cluster-template_delete.md | 2 +- docs/cli/argo_cluster-template_get.md | 2 +- docs/cli/argo_cluster-template_lint.md | 2 +- docs/cli/argo_cluster-template_list.md | 2 +- docs/cli/argo_cluster-template_update.md | 2 +- docs/cli/argo_completion.md | 2 +- docs/cli/argo_cp.md | 2 +- docs/cli/argo_cron.md | 2 +- docs/cli/argo_cron_create.md | 2 +- docs/cli/argo_cron_delete.md | 2 +- docs/cli/argo_cron_get.md | 2 +- docs/cli/argo_cron_lint.md | 2 +- docs/cli/argo_cron_list.md | 2 +- docs/cli/argo_cron_resume.md | 2 +- docs/cli/argo_cron_suspend.md | 2 +- docs/cli/argo_cron_update.md | 2 +- docs/cli/argo_delete.md | 2 +- docs/cli/argo_executor-plugin.md | 2 +- docs/cli/argo_executor-plugin_build.md | 2 +- docs/cli/argo_get.md | 2 +- docs/cli/argo_lint.md | 2 +- docs/cli/argo_list.md | 2 +- docs/cli/argo_logs.md | 2 +- docs/cli/argo_node.md | 2 +- docs/cli/argo_resubmit.md | 2 +- docs/cli/argo_resume.md | 2 +- docs/cli/argo_retry.md | 2 +- docs/cli/argo_server.md | 6 +++--- docs/cli/argo_stop.md | 2 +- docs/cli/argo_submit.md | 2 +- docs/cli/argo_suspend.md | 2 +- docs/cli/argo_template.md | 2 +- docs/cli/argo_template_create.md | 2 +- docs/cli/argo_template_delete.md | 2 +- docs/cli/argo_template_get.md | 2 +- docs/cli/argo_template_lint.md | 2 +- docs/cli/argo_template_list.md | 2 +- docs/cli/argo_template_update.md | 2 +- docs/cli/argo_terminate.md | 2 +- docs/cli/argo_version.md | 2 +- docs/cli/argo_wait.md | 2 +- docs/cli/argo_watch.md | 2 +- docs/environment-variables.md | 2 -- docs/upgrading.md | 12 ++++++++++++ 61 files changed, 77 insertions(+), 78 deletions(-) diff --git a/cmd/argo/commands/client/conn.go b/cmd/argo/commands/client/conn.go index 995c9ee76a57..2c8f100c28d0 100644 --- a/cmd/argo/commands/client/conn.go +++ b/cmd/argo/commands/client/conn.go @@ -45,7 +45,7 @@ func AddAPIClientFlagsToCmd(cmd *cobra.Command) { cmd.PersistentFlags().StringVar(&instanceID, "instanceid", os.Getenv("ARGO_INSTANCEID"), "submit with a specific controller's instance id label. Default to the ARGO_INSTANCEID environment variable.") // "-s" like kubectl cmd.PersistentFlags().StringVarP(&ArgoServerOpts.URL, "argo-server", "s", os.Getenv("ARGO_SERVER"), "API server `host:port`. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable.") - cmd.PersistentFlags().StringVar(&ArgoServerOpts.Path, "argo-base-href", os.Getenv("ARGO_BASE_HREF"), "Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable.") + cmd.PersistentFlags().StringVar(&ArgoServerOpts.Path, "argo-base-href", os.Getenv("ARGO_BASE_HREF"), "Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable.") cmd.PersistentFlags().BoolVar(&ArgoServerOpts.HTTP1, "argo-http1", os.Getenv("ARGO_HTTP1") == "true", "If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable.") cmd.PersistentFlags().StringSliceVarP(&ArgoServerOpts.Headers, "header", "H", []string{}, "Sets additional header to all requests made by Argo CLI. (Can be repeated multiple times to add multiple headers, also supports comma separated headers) Used only when either ARGO_HTTP1 or --argo-http1 is set to true.") // "-e" for encrypted - like zip diff --git a/cmd/argo/commands/root.go b/cmd/argo/commands/root.go index 687b61f85702..0e652f576346 100644 --- a/cmd/argo/commands/root.go +++ b/cmd/argo/commands/root.go @@ -84,7 +84,7 @@ Use the same configuration as GRPC mode, but also set: ARGO_HTTP1=true -If your server is behind an ingress with a path (you'll be running "argo server --basehref /...) or "BASE_HREF=/... argo server"): +If your server is behind an ingress with a path (running "argo server --base-href /argo" or "ARGO_BASE_HREF=/argo argo server"): ARGO_BASE_HREF=/argo `, diff --git a/cmd/argo/commands/server.go b/cmd/argo/commands/server.go index d9860b30ea69..183e9d941b0e 100644 --- a/cmd/argo/commands/server.go +++ b/cmd/argo/commands/server.go @@ -4,7 +4,6 @@ import ( "context" "crypto/tls" "fmt" - "os" "reflect" "strings" "time" @@ -191,18 +190,8 @@ See %s`, help.ArgoServer), }, } - defaultBaseHRef := os.Getenv("BASE_HREF") - if defaultBaseHRef == "" { - defaultBaseHRef = "/" - } - - defaultAllowedLinkProtocol := []string{"http", "https"} - if protocol := os.Getenv("ALLOWED_LINK_PROTOCOL"); protocol != "" { - defaultAllowedLinkProtocol = strings.Split(protocol, ",") - } - command.Flags().IntVarP(&port, "port", "p", 2746, "Port to listen on") - command.Flags().StringVar(&baseHRef, "basehref", defaultBaseHRef, "Value for base href in index.html. Used if the server is running behind reverse proxy under subpath different from /. Defaults to the environment variable BASE_HREF.") + command.Flags().StringVar(&baseHRef, "base-href", "/", "Value for base href in index.html. Used if the server is running behind reverse proxy under subpath different from /.") // "-e" for encrypt, like zip command.Flags().BoolVarP(&secure, "secure", "e", true, "Whether or not we should listen on TLS.") command.Flags().StringVar(&tlsCertificateSecretName, "tls-certificate-secret-name", "", "The name of a Kubernetes secret that contains the server certificates") @@ -218,7 +207,7 @@ See %s`, help.ArgoServer), command.Flags().StringVar(&frameOptions, "x-frame-options", "DENY", "Set X-Frame-Options header in HTTP responses.") command.Flags().StringVar(&accessControlAllowOrigin, "access-control-allow-origin", "", "Set Access-Control-Allow-Origin header in HTTP responses.") command.Flags().Uint64Var(&apiRateLimit, "api-rate-limit", 1000, "Set limit per IP for api ratelimiter") - command.Flags().StringArrayVar(&allowedLinkProtocol, "allowed-link-protocol", defaultAllowedLinkProtocol, "Allowed protocols for links feature. Defaults to the environment variable ALLOWED_LINK_PROTOCOL: http,https") + command.Flags().StringArrayVar(&allowedLinkProtocol, "allowed-link-protocol", []string{"http", "https"}, "Allowed protocols for links feature.") command.Flags().StringVar(&logFormat, "log-format", "text", "The formatter to use for logs. One of: text|json") command.Flags().Float32Var(&kubeAPIQPS, "kube-api-qps", 20.0, "QPS to use while talking with kube-apiserver.") command.Flags().IntVar(&kubeAPIBurst, "kube-api-burst", 30, "Burst to use while talking with kube-apiserver.") diff --git a/docs/argo-server.md b/docs/argo-server.md index 3c84a03df1e5..2c20a6cb50a0 100644 --- a/docs/argo-server.md +++ b/docs/argo-server.md @@ -48,7 +48,7 @@ See [managed namespace](managed-namespace.md). ### Base HREF If the server is running behind reverse proxy with a sub-path different from `/` (for example, -`/argo`), you can set an alternative sub-path with the `--basehref` flag or the `BASE_HREF` +`/argo`), you can set an alternative sub-path with the `--base-href` flag or the `ARGO_BASE_HREF` environment variable. You probably now should [read how to set-up an ingress](#ingress) @@ -97,7 +97,7 @@ argo-server LoadBalancer 10.43.43.130 172.18.0.2 2746:30008/TCP 18h You can get ingress working as follows: -Add `BASE_HREF` as environment variable to `deployment/argo-server`. Do not forget to add a trailing '/' character. +Add `ARGO_BASE_HREF` as environment variable to `deployment/argo-server`. Do not forget to add a trailing '/' character. ```yaml --- @@ -118,7 +118,7 @@ spec: - args: - server env: - - name: BASE_HREF + - name: ARGO_BASE_HREF value: /argo/ image: argoproj/argocli:latest name: argo-server diff --git a/docs/cli/argo.md b/docs/cli/argo.md index 535f687e6494..cbba7ddf43b7 100644 --- a/docs/cli/argo.md +++ b/docs/cli/argo.md @@ -57,7 +57,7 @@ Use the same configuration as GRPC mode, but also set: ARGO_HTTP1=true -If your server is behind an ingress with a path (you'll be running "argo server --basehref /...) or "BASE_HREF=/... argo server"): +If your server is behind an ingress with a path (running "argo server --base-href /argo" or "ARGO_BASE_HREF=/argo argo server"): ARGO_BASE_HREF=/argo @@ -69,7 +69,7 @@ argo [flags] ### Options ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_archive.md b/docs/cli/argo_archive.md index 7dbd1a4ee629..206a5e70e760 100644 --- a/docs/cli/argo_archive.md +++ b/docs/cli/argo_archive.md @@ -15,7 +15,7 @@ argo archive [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_archive_delete.md b/docs/cli/argo_archive_delete.md index aaa039864af5..9ea605dece80 100644 --- a/docs/cli/argo_archive_delete.md +++ b/docs/cli/argo_archive_delete.md @@ -15,7 +15,7 @@ argo archive delete UID... [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_archive_get.md b/docs/cli/argo_archive_get.md index 82a3021030e8..25019af793fe 100644 --- a/docs/cli/argo_archive_get.md +++ b/docs/cli/argo_archive_get.md @@ -16,7 +16,7 @@ argo archive get UID [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_archive_list-label-keys.md b/docs/cli/argo_archive_list-label-keys.md index f13c6ade7d0c..c853e40f2bc9 100644 --- a/docs/cli/argo_archive_list-label-keys.md +++ b/docs/cli/argo_archive_list-label-keys.md @@ -15,7 +15,7 @@ argo archive list-label-keys [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_archive_list-label-values.md b/docs/cli/argo_archive_list-label-values.md index ec37a826c62f..a125ca64a271 100644 --- a/docs/cli/argo_archive_list-label-values.md +++ b/docs/cli/argo_archive_list-label-values.md @@ -16,7 +16,7 @@ argo archive list-label-values [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_archive_list.md b/docs/cli/argo_archive_list.md index 31d56e9c9a55..13de7b0df279 100644 --- a/docs/cli/argo_archive_list.md +++ b/docs/cli/argo_archive_list.md @@ -18,7 +18,7 @@ argo archive list [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_archive_resubmit.md b/docs/cli/argo_archive_resubmit.md index cc0fbf150147..d611c470cabd 100644 --- a/docs/cli/argo_archive_resubmit.md +++ b/docs/cli/argo_archive_resubmit.md @@ -57,7 +57,7 @@ argo archive resubmit [WORKFLOW...] [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_archive_retry.md b/docs/cli/argo_archive_retry.md index be828d5b5e79..482785fdf977 100644 --- a/docs/cli/argo_archive_retry.md +++ b/docs/cli/argo_archive_retry.md @@ -57,7 +57,7 @@ argo archive retry [WORKFLOW...] [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_auth.md b/docs/cli/argo_auth.md index 07aa8aba1035..ec4756c63b64 100644 --- a/docs/cli/argo_auth.md +++ b/docs/cli/argo_auth.md @@ -15,7 +15,7 @@ argo auth [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_auth_token.md b/docs/cli/argo_auth_token.md index bdde309d9bca..5d33d61e8d33 100644 --- a/docs/cli/argo_auth_token.md +++ b/docs/cli/argo_auth_token.md @@ -15,7 +15,7 @@ argo auth token [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_cluster-template.md b/docs/cli/argo_cluster-template.md index 8f3a3e3fb8d9..e2dd6cd549e9 100644 --- a/docs/cli/argo_cluster-template.md +++ b/docs/cli/argo_cluster-template.md @@ -15,7 +15,7 @@ argo cluster-template [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_cluster-template_create.md b/docs/cli/argo_cluster-template_create.md index e97c69916503..bc4b218967d3 100644 --- a/docs/cli/argo_cluster-template_create.md +++ b/docs/cli/argo_cluster-template_create.md @@ -31,7 +31,7 @@ argo cluster-template create FILE1 FILE2... [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_cluster-template_delete.md b/docs/cli/argo_cluster-template_delete.md index 39c70ca49ebc..494a8c8d3763 100644 --- a/docs/cli/argo_cluster-template_delete.md +++ b/docs/cli/argo_cluster-template_delete.md @@ -16,7 +16,7 @@ argo cluster-template delete WORKFLOW_TEMPLATE [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_cluster-template_get.md b/docs/cli/argo_cluster-template_get.md index 5848fd3d4c78..883efc666340 100644 --- a/docs/cli/argo_cluster-template_get.md +++ b/docs/cli/argo_cluster-template_get.md @@ -16,7 +16,7 @@ argo cluster-template get CLUSTER WORKFLOW_TEMPLATE... [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_cluster-template_lint.md b/docs/cli/argo_cluster-template_lint.md index 6111ff8cf951..18bb16b208bc 100644 --- a/docs/cli/argo_cluster-template_lint.md +++ b/docs/cli/argo_cluster-template_lint.md @@ -17,7 +17,7 @@ argo cluster-template lint FILE... [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_cluster-template_list.md b/docs/cli/argo_cluster-template_list.md index cf8ccd1cdc7c..569389a572ac 100644 --- a/docs/cli/argo_cluster-template_list.md +++ b/docs/cli/argo_cluster-template_list.md @@ -30,7 +30,7 @@ argo cluster-template list [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_cluster-template_update.md b/docs/cli/argo_cluster-template_update.md index 560844393ad4..67ca6dcb2b33 100644 --- a/docs/cli/argo_cluster-template_update.md +++ b/docs/cli/argo_cluster-template_update.md @@ -31,7 +31,7 @@ argo cluster-template update FILE1 FILE2... [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_completion.md b/docs/cli/argo_completion.md index 6a87292c3de4..132044c9c27f 100644 --- a/docs/cli/argo_completion.md +++ b/docs/cli/argo_completion.md @@ -30,7 +30,7 @@ argo completion SHELL [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_cp.md b/docs/cli/argo_cp.md index c153e9c0fb85..2edcd56432d1 100644 --- a/docs/cli/argo_cp.md +++ b/docs/cli/argo_cp.md @@ -33,7 +33,7 @@ argo cp my-wf output-directory ... [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_cron.md b/docs/cli/argo_cron.md index 2bd7ddbe1ac3..301304f9297c 100644 --- a/docs/cli/argo_cron.md +++ b/docs/cli/argo_cron.md @@ -19,7 +19,7 @@ argo cron [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_cron_create.md b/docs/cli/argo_cron_create.md index b0081fdab765..2cb40665337d 100644 --- a/docs/cli/argo_cron_create.md +++ b/docs/cli/argo_cron_create.md @@ -25,7 +25,7 @@ argo cron create FILE1 FILE2... [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_cron_delete.md b/docs/cli/argo_cron_delete.md index ec4b893ca884..38f616668a66 100644 --- a/docs/cli/argo_cron_delete.md +++ b/docs/cli/argo_cron_delete.md @@ -16,7 +16,7 @@ argo cron delete [CRON_WORKFLOW... | --all] [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_cron_get.md b/docs/cli/argo_cron_get.md index 25376b2320a7..ce50ab0aca4b 100644 --- a/docs/cli/argo_cron_get.md +++ b/docs/cli/argo_cron_get.md @@ -16,7 +16,7 @@ argo cron get CRON_WORKFLOW... [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_cron_lint.md b/docs/cli/argo_cron_lint.md index 4800e78ff0a3..84bc62566701 100644 --- a/docs/cli/argo_cron_lint.md +++ b/docs/cli/argo_cron_lint.md @@ -17,7 +17,7 @@ argo cron lint FILE... [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_cron_list.md b/docs/cli/argo_cron_list.md index 7532620992ec..82ac41d4cc21 100644 --- a/docs/cli/argo_cron_list.md +++ b/docs/cli/argo_cron_list.md @@ -18,7 +18,7 @@ argo cron list [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_cron_resume.md b/docs/cli/argo_cron_resume.md index 3593065f6f24..fae6d6740492 100644 --- a/docs/cli/argo_cron_resume.md +++ b/docs/cli/argo_cron_resume.md @@ -15,7 +15,7 @@ argo cron resume [CRON_WORKFLOW...] [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_cron_suspend.md b/docs/cli/argo_cron_suspend.md index 3695f822ceb9..e20d53eef59c 100644 --- a/docs/cli/argo_cron_suspend.md +++ b/docs/cli/argo_cron_suspend.md @@ -15,7 +15,7 @@ argo cron suspend CRON_WORKFLOW... [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_cron_update.md b/docs/cli/argo_cron_update.md index a83ddec137ad..d7a189aa41b2 100644 --- a/docs/cli/argo_cron_update.md +++ b/docs/cli/argo_cron_update.md @@ -38,7 +38,7 @@ argo cron update FILE1 FILE2... [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_delete.md b/docs/cli/argo_delete.md index 9883cc7fbd20..fb21a6fdb16d 100644 --- a/docs/cli/argo_delete.md +++ b/docs/cli/argo_delete.md @@ -40,7 +40,7 @@ argo delete [--dry-run] [WORKFLOW...|[--all] [--older] [--completed] [--resubmit ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_executor-plugin.md b/docs/cli/argo_executor-plugin.md index 573cf3c1cb79..310d5637c336 100644 --- a/docs/cli/argo_executor-plugin.md +++ b/docs/cli/argo_executor-plugin.md @@ -15,7 +15,7 @@ argo executor-plugin [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_executor-plugin_build.md b/docs/cli/argo_executor-plugin_build.md index 20059d98e718..84ee33bbc906 100644 --- a/docs/cli/argo_executor-plugin_build.md +++ b/docs/cli/argo_executor-plugin_build.md @@ -15,7 +15,7 @@ argo executor-plugin build DIR [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_get.md b/docs/cli/argo_get.md index e28acfcf84c5..3f3ffdcfede4 100644 --- a/docs/cli/argo_get.md +++ b/docs/cli/argo_get.md @@ -32,7 +32,7 @@ argo get WORKFLOW... [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_lint.md b/docs/cli/argo_lint.md index bc7df061adce..0a3bed86fd61 100644 --- a/docs/cli/argo_lint.md +++ b/docs/cli/argo_lint.md @@ -33,7 +33,7 @@ argo lint FILE... [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_list.md b/docs/cli/argo_list.md index db05ef383f92..05ae34c77c5a 100644 --- a/docs/cli/argo_list.md +++ b/docs/cli/argo_list.md @@ -60,7 +60,7 @@ argo list [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_logs.md b/docs/cli/argo_logs.md index 1bab553ae172..30f6cbbefc7b 100644 --- a/docs/cli/argo_logs.md +++ b/docs/cli/argo_logs.md @@ -57,7 +57,7 @@ argo logs WORKFLOW [POD] [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_node.md b/docs/cli/argo_node.md index feecea14138a..dcbdfd2c996b 100644 --- a/docs/cli/argo_node.md +++ b/docs/cli/argo_node.md @@ -32,7 +32,7 @@ argo node ACTION WORKFLOW FLAGS [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_resubmit.md b/docs/cli/argo_resubmit.md index 4d7143b592f9..c3303485ea6e 100644 --- a/docs/cli/argo_resubmit.md +++ b/docs/cli/argo_resubmit.md @@ -65,7 +65,7 @@ argo resubmit [WORKFLOW...] [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_resume.md b/docs/cli/argo_resume.md index 9eb05e0fe558..e265cc4e7ab4 100644 --- a/docs/cli/argo_resume.md +++ b/docs/cli/argo_resume.md @@ -37,7 +37,7 @@ argo resume WORKFLOW1 WORKFLOW2... [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_retry.md b/docs/cli/argo_retry.md index 2f4f5eb04545..e4a562c1be73 100644 --- a/docs/cli/argo_retry.md +++ b/docs/cli/argo_retry.md @@ -68,7 +68,7 @@ argo retry [WORKFLOW...] [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_server.md b/docs/cli/argo_server.md index 7ec3065fa57a..cd407c6c20f0 100644 --- a/docs/cli/argo_server.md +++ b/docs/cli/argo_server.md @@ -17,10 +17,10 @@ See https://argo-workflows.readthedocs.io/en/latest/argo-server/ ``` --access-control-allow-origin string Set Access-Control-Allow-Origin header in HTTP responses. - --allowed-link-protocol stringArray Allowed protocols for links feature. Defaults to the environment variable ALLOWED_LINK_PROTOCOL: http,https (default [http,https]) + --allowed-link-protocol stringArray Allowed protocols for links feature. (default [http,https]) --api-rate-limit uint Set limit per IP for api ratelimiter (default 1000) --auth-mode stringArray API server authentication mode. Any 1 or more length permutation of: client,server,sso (default [client]) - --basehref string Value for base href in index.html. Used if the server is running behind reverse proxy under subpath different from /. Defaults to the environment variable BASE_HREF. (default "/") + --base-href string Value for base href in index.html. Used if the server is running behind reverse proxy under subpath different from /. (default "/") -b, --browser enable automatic launching of the browser [local mode] --configmap string Name of K8s configmap to retrieve workflow controller configuration (default "workflow-controller-configmap") --event-async-dispatch dispatch event async @@ -42,7 +42,7 @@ See https://argo-workflows.readthedocs.io/en/latest/argo-server/ ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_stop.md b/docs/cli/argo_stop.md index 68bfc27b9466..f241fa749922 100644 --- a/docs/cli/argo_stop.md +++ b/docs/cli/argo_stop.md @@ -45,7 +45,7 @@ argo stop WORKFLOW WORKFLOW2... [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_submit.md b/docs/cli/argo_submit.md index 32ef4ce169bf..2cc6a625e136 100644 --- a/docs/cli/argo_submit.md +++ b/docs/cli/argo_submit.md @@ -63,7 +63,7 @@ argo submit [FILE... | --from `kind/name] [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_suspend.md b/docs/cli/argo_suspend.md index 9e826fa0369b..aa78eb5ea1d9 100644 --- a/docs/cli/argo_suspend.md +++ b/docs/cli/argo_suspend.md @@ -27,7 +27,7 @@ argo suspend WORKFLOW1 WORKFLOW2... [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_template.md b/docs/cli/argo_template.md index 0f3bf23e2f4a..dda6ad794d0a 100644 --- a/docs/cli/argo_template.md +++ b/docs/cli/argo_template.md @@ -15,7 +15,7 @@ argo template [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_template_create.md b/docs/cli/argo_template_create.md index adf5899667bd..63be759940c4 100644 --- a/docs/cli/argo_template_create.md +++ b/docs/cli/argo_template_create.md @@ -17,7 +17,7 @@ argo template create FILE1 FILE2... [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_template_delete.md b/docs/cli/argo_template_delete.md index 219e2fa78f99..71567990c2ee 100644 --- a/docs/cli/argo_template_delete.md +++ b/docs/cli/argo_template_delete.md @@ -16,7 +16,7 @@ argo template delete WORKFLOW_TEMPLATE [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_template_get.md b/docs/cli/argo_template_get.md index a4133ebf22da..054abb1cba3d 100644 --- a/docs/cli/argo_template_get.md +++ b/docs/cli/argo_template_get.md @@ -16,7 +16,7 @@ argo template get WORKFLOW_TEMPLATE... [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_template_lint.md b/docs/cli/argo_template_lint.md index dd491c538099..edab69f8e918 100644 --- a/docs/cli/argo_template_lint.md +++ b/docs/cli/argo_template_lint.md @@ -17,7 +17,7 @@ argo template lint (DIRECTORY | FILE1 FILE2 FILE3...) [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_template_list.md b/docs/cli/argo_template_list.md index fe0438114d23..4f951734eda0 100644 --- a/docs/cli/argo_template_list.md +++ b/docs/cli/argo_template_list.md @@ -17,7 +17,7 @@ argo template list [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_template_update.md b/docs/cli/argo_template_update.md index 970ddb0cbb81..ed2ab0daf9ad 100644 --- a/docs/cli/argo_template_update.md +++ b/docs/cli/argo_template_update.md @@ -31,7 +31,7 @@ argo template update FILE1 FILE2... [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_terminate.md b/docs/cli/argo_terminate.md index f5f1a307612e..f91a7a165ea8 100644 --- a/docs/cli/argo_terminate.md +++ b/docs/cli/argo_terminate.md @@ -43,7 +43,7 @@ argo terminate WORKFLOW WORKFLOW2... [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_version.md b/docs/cli/argo_version.md index 9bc3eb34b8f5..8114811c94d1 100644 --- a/docs/cli/argo_version.md +++ b/docs/cli/argo_version.md @@ -16,7 +16,7 @@ argo version [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_wait.md b/docs/cli/argo_wait.md index c4c637fa9b3e..3b1524311a89 100644 --- a/docs/cli/argo_wait.md +++ b/docs/cli/argo_wait.md @@ -29,7 +29,7 @@ argo wait [WORKFLOW...] [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/cli/argo_watch.md b/docs/cli/argo_watch.md index 8e6d5b2fcc77..8cfdba0a4d53 100644 --- a/docs/cli/argo_watch.md +++ b/docs/cli/argo_watch.md @@ -30,7 +30,7 @@ argo watch WORKFLOW [flags] ### Options inherited from parent commands ``` - --argo-base-href string Path to use with HTTP client due to BASE_HREF. Defaults to the ARGO_BASE_HREF environment variable. + --argo-base-href string Path to use with HTTP client due to Base HREF. Defaults to the ARGO_BASE_HREF environment variable. --argo-http1 If true, use the HTTP client. Defaults to the ARGO_HTTP1 environment variable. -s, --argo-server host:port API server host:port. e.g. localhost:2746. Defaults to the ARGO_SERVER environment variable. --as string Username to impersonate for the operation diff --git a/docs/environment-variables.md b/docs/environment-variables.md index 8237692361b3..c9a56c852f6b 100644 --- a/docs/environment-variables.md +++ b/docs/environment-variables.md @@ -123,11 +123,9 @@ data: | Name | Type | Default | Description | |--------------------------------------------|----------|---------|-------------------------------------------------------------------------------------------------------------------------| -| `ALLOWED_LINK_PROTOCOL` | `string` | `http,https` | List of comma separated protocols allowed for the [Links feature](links.md) | `ARGO_ARTIFACT_SERVER` | `bool` | `true` | Enable [Workflow Archive](workflow-archive.md) endpoints | `ARGO_PPROF` | `bool` | `false` | Enable [`pprof`](https://go.dev/blog/pprof) endpoints | `ARGO_SERVER_METRICS_AUTH` | `bool` | `true` | Enable auth on the `/metrics` endpoint -| `BASE_HREF` | `string` | `/` | [Base HREF](argo-server.md#base-href) of the Server | `DISABLE_VALUE_LIST_RETRIEVAL_KEY_PATTERN` | `string` | `""` | Disable the retrieval of the list of label values for keys based on this regular expression. | | `FIRST_TIME_USER_MODAL` | `bool` | `true` | Show this modal. | | `FEEDBACK_MODAL` | `bool` | `true` | Show this modal. | diff --git a/docs/upgrading.md b/docs/upgrading.md index edcf92986c25..6ac60775eefb 100644 --- a/docs/upgrading.md +++ b/docs/upgrading.md @@ -3,6 +3,18 @@ Breaking changes typically (sometimes we don't realise they are breaking) have "!" in the commit message, as per the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/#summary). +## Upgrading to v3.6 + +### Fixed Server `--basehref` inconsistency + +For consistency, the Server now uses `--base-href` and `ARGO_BASE_HREF`. +Previously it was `--basehref` (no dash in between) and `ARGO_BASEHREF` (no underscore in between). + +### Removed redundant Server environment variables + +`ALLOWED_LINK_PROTOCOL` and `BASE_HREF` have been removed as redundant. +Use `ARGO_ALLOWED_LINK_PROTOCOL` and `ARGO_BASE_HREF` instead. + ## Upgrading to v3.5 There are no known breaking changes in this release. Please file an issue if you encounter any unexpected problems after upgrading.