-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add WorkflowTemplate name as label when using workflowTemplateRef
. Fixes #12670
#12677
base: main
Are you sure you want to change the base?
Conversation
…kflow is submitted from a WorkflowTemplate Signed-off-by: eduardodbr <eduardodbr@hotmail.com>
Signed-off-by: eduardodbr <eduardodbr@hotmail.com>
Signed-off-by: eduardodbr <eduardodbr@hotmail.com>
Signed-off-by: eduardodbr <eduardodbr@hotmail.com>
workflowTemplateRef
. Fixes #12670
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small comments, but otherwise LGTM. There are also some merge conflicts now as well to resolve
@eduardodbr would you be able to include cronworkflow name too? |
Signed-off-by: Eduardo Rodrigues <eduardodbr@hotmail.com>
Signed-off-by: Eduardo Rodrigues <eduardodbr@hotmail.com>
Signed-off-by: Eduardo Rodrigues <eduardodbr@hotmail.com>
Signed-off-by: Eduardo Rodrigues <eduardodbr@hotmail.com>
If a cronworkflow uses a templateRef, the child workflow will have a label with the cron workflow name and other label with the template name |
Fixes #12670
Motivation
Modifications
Verification
Create a workflow Template
Launch a Workflow or a CronWorkflow from the workflowTemplate
The workflow should have the label: