Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: "Finished before" field only affects visible Workflows #13151

Open
3 of 4 tasks
abschm opened this issue Jun 6, 2024 · 4 comments
Open
3 of 4 tasks

UI: "Finished before" field only affects visible Workflows #13151

abschm opened this issue Jun 6, 2024 · 4 comments
Labels
area/api Argo Server API area/ui area/workflow-archive type/bug type/regression Regression from previous behavior (a specific type of bug)

Comments

@abschm
Copy link

abschm commented Jun 6, 2024

Pre-requisites

  • I have double-checked my configuration
  • I have tested with the :latest image tag (i.e. quay.io/argoproj/workflow-controller:latest) and can confirm the issue still exists on :latest. If not, I have explained why, in detail, in my description below.
  • I have searched existing issues and could not find a match for this bug
  • I'd like to contribute the fix myself (see contributing guide)

What happened/what did you expect to happen?

In 3.5.7, the "Finished before" field in the UI doesn't work properly. It only filters and displays results from the first page of workflows. This means if you enter a date that is before the dates of the workflows on first page, nothing shows up.

image
image
image

Version

3.5.7

Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

N/A

Logs from the workflow controller

N/A

Logs from in your workflow's wait container

N/A
@abschm abschm added the type/bug label Jun 6, 2024
@agilgur5 agilgur5 changed the title "Finished before" field in UI doesn't work UI: "Finished before" field only affects visible Workflows Jun 6, 2024
@agilgur5
Copy link
Contributor

agilgur5 commented Jun 6, 2024

In 3.5.7, the "Finished before" field in the UI doesn't work properly

This isn't new to 3.5.7; for live Workflows, this has always been the case for the UI and CLI because k8s/etcd does not have a native date filter, so they were only filtered client-side. This was mentioned in #11840, #12025 (comment), and #12025 (comment) part 3.

As of #13021 / #12736, which was released in 3.5.7, this is now possible to implement natively for live Workflows as the Server now has a SQLite cache.

Prior to 3.5 / #11121, Archived Workflows were in a separate page in the UI and had a native date filter (as the Workflow Archive uses a SQL DB). Similar to #12161 in that respect; this is a regression for Archived Workflows, but a feature for unarchived workflows.

@agilgur5 agilgur5 added area/api Argo Server API area/ui labels Jun 6, 2024
@agilgur5 agilgur5 added this to the v3.5.x patches milestone Jun 6, 2024
@agilgur5 agilgur5 added type/regression Regression from previous behavior (a specific type of bug) area/workflow-archive labels Jun 9, 2024
@agilgur5
Copy link
Contributor

agilgur5 commented Jun 9, 2024

@Adrien-D you might be interested in implementing this one as it is similar to #12161. It might be easier than the name filters even, but it does require updating the CLI as well

@Adrien-D
Copy link
Member

@agilgur5 sure I will have a look at this one

@tooptoop4
Copy link
Contributor

where @Adrien-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Argo Server API area/ui area/workflow-archive type/bug type/regression Regression from previous behavior (a specific type of bug)
Projects
None yet
Development

No branches or pull requests

4 participants