Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WorkflowTemplate resolution should happen once #1525

Closed
jessesuen opened this issue Aug 5, 2019 · 2 comments
Closed

WorkflowTemplate resolution should happen once #1525

jessesuen opened this issue Aug 5, 2019 · 2 comments
Assignees
Labels
type/feature Feature request

Comments

@jessesuen
Copy link
Member

Spawned from #1312 (comment)

When resolving workflow templates, we should do this once when we start processing the workflow, and store the resolved templates in status. This will handle the problem of templates changing their meaning, or disappearing while workflows are running.

There's also the question about how to handle retry of workflows which are using templates. I feel behavior should be as follows:

  1. argo retry should not re-resolve workflow templates
  2. argo resubmit should re-resolve any workflow templates

We could consider adding flags to re-resolve templates or not during those two commands.

@jessesuen jessesuen added the type/feature Feature request label Aug 5, 2019
@dtaniwaki dtaniwaki self-assigned this Aug 5, 2019
@jessesuen
Copy link
Member Author

One corner case:

  1. argo resubmit --memoized should probably re-use resolved workflow templates. I think we need to re-use the resolved templates because it is re-using prior node status information, and allowing templates to change meaning during resubmit may have inconsistent results.

@simster7
Copy link
Member

Closing as resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature Feature request
Projects
None yet
Development

No branches or pull requests

3 participants