Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable all linters in golangci-lint and fix current lint issues #1737

Closed
simster7 opened this issue Nov 5, 2019 · 0 comments · Fixed by #1739
Closed

Enable all linters in golangci-lint and fix current lint issues #1737

simster7 opened this issue Nov 5, 2019 · 0 comments · Fixed by #1739
Assignees
@simster7
Labels
type/feature Feature request

Comments

@simster7
Copy link
Member

simster7 commented Nov 5, 2019 •
edited
Loading

Currently we do not have all liners enabled in golangci-lint and therefore some of our files have lint issues, so we should fix them and enable all linters.
@simster7 simster7 added the type/feature Feature request label Nov 5, 2019
@simster7 simster7 self-assigned this Nov 5, 2019
@simster7 simster7 changed the title Enable --fix in golangci-lint and fix current lint issues Enable all linters in golangci-lint and fix current lint issues Nov 5, 2019
@simster7 simster7 mentioned this issue Nov 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simster7 simster7

Labels
type/feature Feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed lint issues simster7/argo
1 participant
@simster7