From bcc91dacc771dc61c4a6f24658765deb45556350 Mon Sep 17 00:00:00 2001 From: Simon Behar Date: Mon, 21 Oct 2019 13:27:00 -0700 Subject: [PATCH 1/2] Fixes bugs in demo Fixes: https://github.com/argoproj/argo/issues/1683 --- demo.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/demo.md b/demo.md index 595f87f05186..ac916b29900c 100644 --- a/demo.md +++ b/demo.md @@ -41,7 +41,7 @@ To run all of the examples in this guide, the 'default' service account is too l features such as artifacts, outputs, access to secrets, etc... For demo purposes, run the following command to grant admin privileges to the 'default' service account in the namespace 'default': ``` -kubectl create rolebinding default-admin --clusterrole=admin --serviceaccount=argo:default +kubectl create rolebinding default-admin --clusterrole=admin --serviceaccount=default:default ``` For the bare minimum set of privileges which a workflow needs to function, see [Workflow RBAC](docs/workflow-rbac.md). You can also submit workflows which run with a different @@ -60,6 +60,8 @@ argo get xxx-workflow-name-xxx argo logs xxx-pod-name-xxx #from get command above ``` +Make sure you run these examples while on the `default` namespace (since we granted admin privileges only within `default` on the previous step). + You can also create workflows directly with kubectl. However, the Argo CLI offers extra features that kubectl does not, such as YAML validation, workflow visualization, parameter passing, retries and resubmits, suspend and resume, and more. @@ -90,7 +92,7 @@ helm install stable/minio \ Login to the Minio UI using a web browser (port 9000) after exposing obtaining the external IP using `kubectl`. ``` -kubectl get service argo-artifacts -o wide +kubectl -n argo get service argo-artifacts -o wide ``` On Minikube: ``` From 74fc3326abd700ab69c3997b88f09a29052aba58 Mon Sep 17 00:00:00 2001 From: Simon Behar Date: Tue, 22 Oct 2019 14:57:50 -0700 Subject: [PATCH 2/2] Update demo.md --- demo.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/demo.md b/demo.md index ac916b29900c..ac80b4371f17 100644 --- a/demo.md +++ b/demo.md @@ -39,7 +39,7 @@ kubectl create clusterrolebinding YOURNAME-cluster-admin-binding --clusterrole=c To run all of the examples in this guide, the 'default' service account is too limited to support features such as artifacts, outputs, access to secrets, etc... For demo purposes, run the following -command to grant admin privileges to the 'default' service account in the namespace 'default': +command to grant admin privileges to the 'default' service account in the namespace 'default'. Make sure you are on the 'default' namespace before running them. ``` kubectl create rolebinding default-admin --clusterrole=admin --serviceaccount=default:default ```