fix(controller): When semaphore lock config gets updated, enqueue the waiting workflows #4421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… waiting workflows Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>
Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>
Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>
sarabala1979
commented
Nov 2, 2020
| @@ -262,6 +284,56 @@ func (wfc *WorkflowController) createSynchronizationManager() error { | |||
| return nil | |||
| } | |||
|
|
|||
| func (wfc *WorkflowController) runConfigMapWatcher(stopCh <-chan struct{}) { | |||
| retryWatcher, err := apiwatch.NewRetryWatcher("1", &cache.ListWatch{ | |||
There was a problem hiding this comment.
Watcher is watching all configmap across namespace, We don't know the configmap name to get the version, so initialResourceVersion =1
jessesuen
reviewed
Nov 2, 2020
jessesuen
reviewed
Nov 3, 2020
jessesuen
approved these changes
Nov 5, 2020
alexec
pushed a commit
that referenced
this pull request
Nov 6, 2020
… waiting workflows (#4421) Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com> Signed-off-by: Alex Collins <alex_collins@intuit.com>
alexcapras
pushed a commit
to alexcapras/argo
that referenced
this pull request
Nov 12, 2020
… waiting workflows (argoproj#4421) Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com> Signed-off-by: Alex Capras <alexcapras@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Saravanan Balasubramanian sarabala1979@gmail.com
Checklist:
"fix(controller): Updates such and such. Fixes #1234".Fixes Changes to workflow semaphore seems not to trigger reload semaphore state in workflow-controller #4327