Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): label autocomplete for report tab #6881

Merged
merged 2 commits into from
Oct 8, 2021

Conversation

tczhao
Copy link
Member

@tczhao tczhao commented Oct 7, 2021

Like #6776, but for the Reports tab

Untitled_.Oct.8.2021.10_00.AM.mp4

Tips:

  • Maybe add you organization to USERS.md.
  • Your PR needs to pass the required checks before it can be approved. If the check is not required (e.g. E2E tests) it does not need to pass
  • Sign-off your commits to pass the DCO check: git commit --signoff.
  • Run make pre-commit -B to fix codegen or lint problems.
  • Say how how you tested your changes. If you changed the UI, attach screenshots.
  • If changes were requested, and you've made them, then dismis the review to get it looked at again.
  • You can ask for help!

Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #6881 (4f6abd3) into master (689ad68) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6881      +/-   ##
==========================================
- Coverage   48.55%   48.50%   -0.05%     
==========================================
  Files         265      265              
  Lines       19220    19258      +38     
==========================================
+ Hits         9332     9342      +10     
- Misses       8839     8863      +24     
- Partials     1049     1053       +4     
Impacted Files Coverage Δ
workflow/controller/operator.go 71.06% <0.00%> (-0.15%) ⬇️
persist/sqldb/migrate.go 0.00% <0.00%> (ø)
pkg/apiclient/http1-client.go 0.00% <0.00%> (ø)
persist/sqldb/workflow_archive.go 0.00% <0.00%> (ø)
pkg/apiclient/argo-kube-client.go 0.00% <0.00%> (ø)
pkg/apiclient/argo-server-client.go 0.00% <0.00%> (ø)
pkg/apiclient/offline-workflow-service-client.go 0.00% <0.00%> (ø)
...ient/argo-kube-workflow-template-service-client.go 0.00% <0.00%> (ø)
.../error-translating-cron-workflow-service-client.go 0.00% <0.00%> (ø)
server/workflowarchive/archived_workflow_server.go 59.43% <0.00%> (+0.38%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 689ad68...4f6abd3. Read the comment docs.

@alexec
Copy link
Contributor

alexec commented Oct 7, 2021

Please add screenshot or video in action.

Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
@tczhao
Copy link
Member Author

tczhao commented Oct 8, 2021

Video added

@alexec alexec merged commit 2fd4b8a into argoproj:master Oct 8, 2021
This was referenced Oct 15, 2021
kriti-sc pushed a commit to kriti-sc/argo-workflows that referenced this pull request Oct 24, 2021
Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
Signed-off-by: kriti-sc <kathuriakriti1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants