Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wait-on issue doesn't play well with webpack-dev-server #236

Closed
hegelstad opened this issue May 2, 2019 · 1 comment
Closed

wait-on issue doesn't play well with webpack-dev-server #236

hegelstad opened this issue May 2, 2019 · 1 comment

Comments

@hegelstad
Copy link

💥 Regression Report

Last working version

Worked up to version: 4.0.0

Stopped working in version: 4.0.0

To Reproduce

Steps to reproduce the behavior:
Use webpack-dev-server and expect tests to start after compilation
The new wait-on package will not be able to parse the ok 200 status because it only listens for HEAD requests not GET requests... see https://github.com/bahmutov/start-server-and-test#note-for-webpack-dev-server-users

Expected behavior

It should work like before changing to wait-on

*** Clipboard option removed - use clipboardy or clipboard-cli directly ***


## System:
 - OS: macOS Mojave 10.14.3
 - CPU: (4) x64 Intel(R) Core(TM) i5-7267U CPU @ 3.10GHz
 - Memory: 1.24 GB / 16.00 GB
 - Shell: 5.3 - /bin/zsh
## Binaries:
 - Node: 11.12.0 - /usr/local/bin/node
 - Yarn: 1.15.2 - ~/.yarn/bin/yarn
 - npm: 6.7.0 - /usr/local/bin/npm
 - Watchman: 4.9.0 - /usr/local/bin/watchman
## npmPackages:
 - jest-puppeteer: 4.1.1 => 4.1.1
@xiaoyuhen
Copy link
Contributor

xiaoyuhen commented May 3, 2019

hi @hegelstad

I am very sorry that we upgraded wait-on and caused some issues on your project.

After my tests, this #235 PR will solve this issue.

We will release a new version as soon as possible.

see #233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants