Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with latest Puppeteer version #566

Merged
merged 10 commits into from
Oct 1, 2023
Merged

Fix compatibility with latest Puppeteer version #566

merged 10 commits into from
Oct 1, 2023

Conversation

swissspidy
Copy link
Contributor

Summary

Puppeteer recently changed the naming of their classes in puppeteer/puppeteer#10903, which caused the case-sensitive class name checks in expect-puppeteer to fail.

Fixes #565

Test plan

Puppeteer recently changed the naming of their classes in puppeteer/puppeteer#10903, which caused the case-sensitive class name checks in `expect-puppeteer` to fail.
@swissspidy
Copy link
Contributor Author

@gregberge Prettier issues are now addressed

@gregberge
Copy link
Member

Will take care of it soon.

@gregberge
Copy link
Member

@swissspidy tests are all broken

@gregberge gregberge merged commit 5cfee1f into argos-ci:main Oct 1, 2023
3 checks passed
@swissspidy swissspidy deleted the patch-1 branch October 1, 2023 08:48
@fregante
Copy link

fregante commented Oct 1, 2023

I can confirm this fixed my issue. Thank you!

@jamesgpearce
Copy link

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Puppeteer 21 regression: [object Object] is not supported
4 participants