Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System Idle Process on Windows reports port in use (jest-dev-server) #91

Closed
njbmartin opened this issue Jul 9, 2018 · 2 comments
Closed

System Idle Process on Windows reports port in use (jest-dev-server) #91

njbmartin opened this issue Jul 9, 2018 · 2 comments

Comments

@njbmartin
Copy link

Found an interesting issue related to jest-dev-server in which the port hasn't been fully released on Windows. It can be reused, but it's attached to the "System Idle Process".

https://github.com/smooth-code/jest-puppeteer/blob/cda5a30ec24fd7ae995663aa47f5028cd1a45101/packages/jest-dev-server/src/global.js#L92

This will report System Idle Process as the process currently using the port. This has a process id of 0.

Changing the proceeding line if (portProcess) { to if (portProcess && portProcess.pid > 0) { resolves the issue by asserting that it's not being held by System Idle Process and allows the server to be started.
@gregberge
Copy link
Member

Good catch, can you submit a PR for it?

@njbmartin njbmartin mentioned this issue Jul 11, 2018
Merged
@njbmartin
Copy link
Author

@neoziro That PR is now ready. Are you able to release these this week? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gregberge @njbmartin