Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Building via Actions do not work #132

Open
2 tasks done
neoighodaro opened this issue Sep 24, 2024 · 12 comments
Open
2 tasks done

[Bug] Building via Actions do not work #132

neoighodaro opened this issue Sep 24, 2024 · 12 comments
Labels
bug Something isn't working

Comments

@neoighodaro
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Have you read the FAQ?

  • Yes, I read the FAQ

Device info

  • Github

Describe the bug

Screenshot 2024-09-24 at 18 14 55

Steps to reproduce the issue

  1. Fork
  2. Run action with instructions in wiki

Crash log (if the app crashes)

No response

Are you using the newest version of YouTubeRebornPlus? If not, why?

✅ Yes, I'm using the latest version of YouTubeRebornPlus right now

Does the issue happen with the official YouTube from AppStore?

❌ No, It doesn't

Additional context

No response

@neoighodaro neoighodaro added the bug Something isn't working label Sep 24, 2024
@anburocky3
Copy link

I'm facing the same problem..

@arichornlover
Copy link
Owner

I have fixed the problem. Let me know if it has any other problems.

and sorry the building wasn’t working before. That was because of me being shadowbanned.

@oldman20
Copy link

oldman20 commented Oct 12, 2024

today after sync fork source and update submodules, still error cant build from Github action, use latest YT ipa 19.40.4
many error but end with this

`/Users/runner/work/YouTubeRebornPlus-new-fork/YouTubeRebornPlus-new-fork/main/Tweaks/YouTubeHeader/YTIPivotBarSupportedRenderers.h:6:87: error: expected ';' at end of declaration list
@Property (nonatomic, strong, readwrite) YTIPivotBarItemRenderer *pivotBarItemRenderer

/Users/runner/work/YouTubeRebornPlus-new-fork/YouTubeRebornPlus-new-fork/main/Tweaks/YouTubeHeader/YTIPivotBarSupportedRenderers.h:7:103: error: expected ';' at end of declaration list
@Property (nonatomic, strong, readwrite) YTIPivotBarIconOnlyItemRenderer *pivotBarIconOnlyItemRenderer

12 errors generated.
make[3]: *** [/Users/runner/work/YouTubeRebornPlus-new-fork/YouTubeRebornPlus-new-fork/theos/makefiles/instance/rules.mk:405: /Users/runner/work/YouTubeRebornPlus-new-fork/YouTubeRebornPlus-new-fork/main/.theos/obj/arm64/Source/Settings.xm.0f7ac095.o] Error 1

make[2]: *** [/Users/runner/work/YouTubeRebornPlus-new-fork/YouTubeRebornPlus-new-fork/theos/makefiles/instance/library.mk:52: /Users/runner/work/YouTubeRebornPlus-new-fork/YouTubeRebornPlus-new-fork/main/.theos/obj/arm64/YouTubeRebornPlus.dylib] Error 2

make[1]: *** [/Users/runner/work/YouTubeRebornPlus-new-fork/YouTubeRebornPlus-new-fork/theos/makefiles/instance/library.mk:37: internal-library-all_] Error 2

make: *** [/Users/runner/work/YouTubeRebornPlus-new-fork/YouTubeRebornPlus-new-fork/theos/makefiles/master/rules.mk:146: YouTubeRebornPlus.all.tweak.variables] Error 2
Error: Process completed with exit code 2.`

@jgamoss
Copy link

jgamoss commented Oct 12, 2024

hi, building works with 19.23.3 decrypted YT ipa

@jgamoss
Copy link

jgamoss commented Oct 12, 2024

also works with 19.34.2 YT ipa

@oldman20
Copy link

oldman20 commented Oct 12, 2024

also works with 19.34.2 YT ipa

Thank for let mw know it work. Btw, I found a repo from the author but couldn't build it. Do you know why and how to build it?
https://github.com/arichornloverALT/YouTubeRebornPlus

I tried with 19.34.2 still error unable to build

@jgamoss
Copy link

jgamoss commented Oct 12, 2024

I used this repo https://github.com/arichornlover/YouTubeRebornPlus
and the same method as you
building with ipa https://n9.cl/e53tp

@oldman20
Copy link

huhm, today i tried re-fork then build YT 19.41.3 still cant success, stop at Fix compiling & Build Package

`Run cd /Users/runner/work/YouTubeRebornPlus/YouTubeRebornPlus/main
==> Downloading Reborn…

Making all in Tweaks/Alderis…
Making all for xcodeproj Alderis…
▸ Copying AlderisSDKCompatibility.h
▸ Copying Alderis.h
▸ Processing Info.plist
▸ Compiling Alderis_vers.c
▸ Linking Alderis
▸ Generating 'Alderis.framework.dSYM'
▸ Running script 'SwiftLint'
▸ Touching Alderis.framework (in target 'Alderis' from project 'Alderis')
Run script build phase 'SwiftLint' will be run during every build because it does not specify any outputs. To address this warning, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase. (in target 'Alderis' from project 'Alderis')
▸ Archive Succeeded
==> Signing Alderis…
Making all in lcpshim…
Making all for library libcolorpicker…
==> Compiling HBColorPickerTableCell.m (arm64)…
==> Compiling ColorFunctions.m (arm64)…
==> Compiling PFColorCell.m (arm64)…
==> Compiling PFColorAlert.m (arm64)…
==> Compiling PFSimpleLiteColorCell.m (arm64)…
==> Compiling PFLiteColorCell.m (arm64)…
==> Compiling UIColor+PFColor.m (arm64)…
ld: warning: -multiply_defined is obsolete
==> Linking library libcolorpicker (arm64)…
ld: warning: ignoring duplicate libraries: '-lc++'
==> Generating debug symbols for libcolorpicker…
ld: warning: search path '/Users/runner/work/YouTubeRebornPlus/YouTubeRebornPlus/main/.theos/obj/install/Library/Frameworks' not found
==> Stripping libcolorpicker (arm64)…
ld: warning: search path '/Users/runner/work/YouTubeRebornPlus/YouTubeRebornPlus/main/.theos/obj/install/var/jb/Library/Frameworks' not found
==> Merging library libcolorpicker…
==> Signing libcolorpicker…
Making all in Tweaks/iSponsorBlock…
Making all for tweak iSponsorBlock…
==> Preprocessing iSponsorBlock.xm…
==> Compiling SponsorBlockSettingsController.m (arm64)…
==> Compiling SponsorSegment.m (arm64)…
==> Compiling MBProgressHUD.m (arm64)…
==> Compiling SponsorBlockRequest.m (arm64)…
==> Compiling SponsorBlockViewController.m (arm64)…
==> Compiling SponsorSegmentView.m (arm64)…
==> Compiling iSponsorBlock.xm (arm64)…
ld: warning: -multiply_defined is obsolete
==> Linking tweak iSponsorBlock (arm64)…
ld: warning: ignoring duplicate libraries: '-lc++'
ld: warning: search path '/Users/runner/work/YouTubeRebornPlus/YouTubeRebornPlus/main/.theos/obj/install/Library/Frameworks' not found
==> Generating debug symbols for iSponsorBlock…
==> Stripping iSponsorBlock (arm64)…
==> Merging tweak iSponsorBlock…
==> Signing iSponsorBlock…
Making all in Tweaks/YTUHD…
Making all for tweak YTUHD…
==> Preprocessing Common.x…
Tweak.xm:29: error: %hook does not make sense inside a block
==> Preprocessing Tweak.xm…
make[4]: *** [/Users/runner/work/YouTubeRebornPlus/YouTubeRebornPlus/theos/makefiles/instance/rules.mk:401: /Users/runner/work/YouTubeRebornPlus/YouTubeRebornPlus/main/.theos/obj/arm64/Tweak.xm.mm] Error 255
make[4]: *** Waiting for unfinished jobs....
==> Preprocessing Settings.x…
==> Compiling Common.x (arm64)…
rm /Users/runner/work/YouTubeRebornPlus/YouTubeRebornPlus/main/.theos/obj/arm64/Settings.x.m /Users/runner/work/YouTubeRebornPlus/YouTubeRebornPlus/main/.theos/obj/arm64/Tweak.xm.mm
make[3]: *** [/Users/runner/work/YouTubeRebornPlus/YouTubeRebornPlus/theos/makefiles/instance/library.mk:52: /Users/runner/work/YouTubeRebornPlus/YouTubeRebornPlus/main/.theos/obj/arm64/YTUHD.dylib] Error 2
make[2]: *** [/Users/runner/work/YouTubeRebornPlus/YouTubeRebornPlus/theos/makefiles/instance/library.mk:37: internal-library-all_] Error 2
make[1]: *** [/Users/runner/work/YouTubeRebornPlus/YouTubeRebornPlus/theos/makefiles/master/rules.mk:146: YTUHD.all.tweak.variables] Error 2
make: *** [/Users/runner/work/YouTubeRebornPlus/YouTubeRebornPlus/theos/makefiles/master/aggregate.mk:12: internal-all] Error 2
Error: Process completed with exit code 2.`

@neoighodaro
Copy link
Author

%hook does not make sense inside a block

seems your issue is unrelated at least directly to this repo and more with iSponsorBlock

@oldman20
Copy link

oldman20 commented Nov 6, 2024

What's about this error: i trying build YT 19.4.4 (latest)
"==> Compiling Tweak.xm (arm64)…
/Users/runner/work/YouTubeRebornPlus/YouTubeRebornPlus/theos/vendor/include/substrate.h:45:1: error: import of C++ module 'MachO.nlist' appears within extern "C" language linkage specification [-Wmodule-import-in-extern-c]
rm /Users/runner/work/YouTubeRebornPlus/YouTubeRebornPlus/main/.theos/obj/arm64/Tweak.xm.mm
#include <mach-o/nlist.h>
^
/Users/runner/work/YouTubeRebornPlus/YouTubeRebornPlus/theos/vendor/include/substrate.h:43:1: note: extern "C" language linkage specification begins here
extern "C" {
^
1 error generated.
make[4]: *** [/Users/runner/work/YouTubeRebornPlus/YouTubeRebornPlus/theos/makefiles/instance/rules.mk:405: /Users/runner/work/YouTubeRebornPlus/YouTubeRebornPlus/main/.theos/obj/arm64/Tweak.xm.dfbf2fde.o] Error 1
make[3]: *** [/Users/runner/work/YouTubeRebornPlus/YouTubeRebornPlus/theos/makefiles/instance/library.mk:52: /Users/runner/work/YouTubeRebornPlus/YouTubeRebornPlus/main/.theos/obj/arm64/YTUHD.dylib] Error 2
make[2]: *** [/Users/runner/work/YouTubeRebornPlus/YouTubeRebornPlus/theos/makefiles/instance/library.mk:37: internal-library-all_] Error 2
make[1]: *** [/Users/runner/work/YouTubeRebornPlus/YouTubeRebornPlus/theos/makefiles/master/rules.mk:146: YTUHD.all.tweak.variables] Error 2
make: *** [/Users/runner/work/YouTubeRebornPlus/YouTubeRebornPlus/theos/makefiles/master/aggregate.mk:12: internal-all] Error 2
Error: Process completed with exit code 2.

@arichornlover
Copy link
Owner

I reverted certain changes. Seems like something broke server-side.

@oldman20
Copy link

oldman20 commented Nov 6, 2024

I reverted certain changes. Seems like something broke server-side.

So i can try now again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants