Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] PiP is forced for some videos and background playback often stops working for them #82

Open
2 tasks done
JayceTheBased opened this issue Jan 6, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@JayceTheBased
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Have you read the FAQ?

  • Yes, I read the FAQ

Device info

iOS/iPadOS version: 15.8
Device model: iPhone 7
Sideload tool (AltStore, SideStore, Sideloadly, TrollStore,...): Sidestore
The specific version of YoutubeRebornPlus (latest or newest is NOT a version number!): 18.49.3-4.2.3-2

Describe the bug

Let me just start off by saying thank you so much for your hard work on this app. I really appreciate it.

So I often like to use YouTube to play music on my phone, sometimes while I'm browsing the web or making notes on my phone at the same time. I always have PiP turned off because I don't like it. However, I just noticed that although I have the PiP option disabled, the PiP still pops up for some videos only when I switch apps or go to the home screen. I'm not sure why it consistently pops up for some videos and not others, but I'll include a number of videos that I've noticed the problem with. Also, for these videos, the background playback often stops working as soon as my screen turns off.

I did try enabling the legacy PiP option to see if that changed anything - it didn't seem to.

Steps to reproduce the issue

Here are some videos this issue occurs with:

  1. https://www.youtube.com/watch?v=6wPWFWUsPBw
  2. https://www.youtube.com/watch?v=jiwuQ6UHMQg
  3. https://www.youtube.com/watch?v=b58rgdK9dTI&list=PL-mmvz0wGt0DPr6-0qXZgPdyM2tgt63A5&index=134
  4. https://www.youtube.com/watch?v=nWm_OhIKms8

Crash log (if the app crashes)

No response

Are you using the newest version of YouTubeRebornPlus? If not, why?

✅ Yes, I'm using the latest version of YouTubeRebornPlus right now

Does the issue happen with the official YouTube from AppStore?

❌ No, It doesn't

Additional context

I originally posted this issue over at YTLitePlus but I actually prefer this modded ipa over that one, plus this one seems to be more frequently updated which is great.

@JayceTheBased JayceTheBased added the bug Something isn't working label Jan 6, 2024
@arichornlover
Copy link
Owner

arichornlover commented Jan 6, 2024

So I often like to use YouTube to play music on my phone, sometimes while I'm browsing the web or making notes on my phone at the same time. I always have PiP turned off because I don't like it. However, I just noticed that although I have the PiP option disabled, the PiP still pops up for some videos only when I switch apps or go to the home screen. I'm not sure why it consistently pops up for some videos and not others, but I'll include a number of videos that I've noticed the problem with. Also, for these videos, the background playback often stops working as soon as my screen turns off.

I might be one of those types of users who doesn’t have encounter this issue. However. It could possibly be one of the options related to Video Player in YouTube Reborn Menu or YouTubeRebornPlus settings in the app. If one of them is the reason messing with background play and PiP, I will remove them whenever I release YouTube Reborn v5

I originally posted this issue over at YTLitePlus but I actually prefer this modded ipa over that one, plus this one seems to be more frequently updated which is great.

I appreciate it! But honestly they are both equally good! Yeah they have Pros & Cons in terms of features/options but wouldn’t be that bad!
I’m doing frequent updates to YouTubeRebornPlus a ton since YouTube Reborn v5 is gonna include an improved YouTube Reborn Button & UI Interface and other more stuff that I added in!

@JayceTheBased
Copy link
Author

JayceTheBased commented Mar 16, 2024

I might be one of those types of users who doesn’t have encounter this issue. However. It could possibly be one of the options related to Video Player in YouTube Reborn Menu or YouTubeRebornPlus settings in the app. If one of them is the reason messing with background play and PiP, I will remove them whenever I release YouTube Reborn v5

Thanks for your fast response and sorry my response has been really slow lol. I figured out the problem, it's not anything specific to YouTube Reborn. After thinking about it, I remembered that in the good old days of me having a Galaxy S8 (before I broke it, smh), I had the exact same problem with the Android app YouTube Revanced. To fix it, I just had to disable the PiP in the Android system settings for the YouTube app.

So to fix the problem with this app, I had to do something similar, specifically, I had to turn off "Start Picture in Picture automatically" in the general section of iOS settings. I guess that the issue has something to do with the way the background playback is emulated - probably because it's client side, not server side. Anyway, by changing that setting I got rid of the PiP so you can close this issue if you want.

I appreciate it! But honestly they are both equally good! Yeah they have Pros & Cons in terms of features/options but wouldn’t be that bad! I’m doing frequent updates to YouTubeRebornPlus a ton since YouTube Reborn v5 is gonna include an improved YouTube Reborn Button & UI Interface and other more stuff that I added in!

That's a fair point, they both are good in their own ways indeed. It's good to have multiple options in case there are any problems with one of the apps too. Thanks again of your hard work on this, I use this app to play music everyday and truly appreciate it. I definitely appreciate the sweet UI, in fact it's much better than YouTube Revanced on my Galaxy S8 used to be. And this app has a lot more nice features than YouTube Revanced too.

@arichornlover
Copy link
Owner

arichornlover commented Mar 16, 2024

That's a fair point, they both are good in their own ways indeed. It's good to have multiple options in case there are any problems with one of the apps too. Thanks again of your hard work on this, I use this app to play music everyday and truly appreciate it. I definitely appreciate the sweet UI, in fact it's much better than YouTube Revanced on my Galaxy S8 used to be. And this app has a lot more nice features than YouTube Revanced too.

also be careful with using Reborn v5, it’s still in beta. I’ve always kept changing stuff to make it better. Especially adding more options to expand the beta to be a good release.
also here’s the current “View Downloads” UI in the v5.0.0 Beta so far.
IMG_2657
also the button and the arrow you normally see in v4.2.6 on the right was replaced with the swipe left to action gesture in the v5.0.0 Betas to provide more space for the user. Was wondering if you prefer this over the Previous UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants