Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kirki_modules filter broken #2023

Closed
regenrek opened this issue Nov 16, 2018 · 1 comment
Closed

kirki_modules filter broken #2023

regenrek opened this issue Nov 16, 2018 · 1 comment

Comments

@regenrek
Copy link

Issue description:

Hi,

I can't remove a module from kirki_modules.

Version used:

(Did you try using the develop branch from github? There's a chance your issue has already been adressed there)

Using theme_mods or options?

3.0.34.1

Code to reproduce the issue (config + field(s))

functions.php

add_filter( 'kirki_modules', function($modules) {
	unset( $modules['css-vars'] );
	return $modules;
});

grafik

@aristath
Copy link
Contributor

This was a timing issue.
The methods (and filter) were done on plugins_loaded so it was only possible to change them from a plugin, or mu-plugins.
I changed their priority and now the modules are loaded on after_setup_theme, so it's possible to use the filter from a theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants