Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0.35.3 color control in repeater issues #2059

Closed
AlxMedia opened this issue Jan 15, 2019 · 5 comments
Closed

3.0.35.3 color control in repeater issues #2059

AlxMedia opened this issue Jan 15, 2019 · 5 comments

Comments

@AlxMedia
Copy link
Contributor

AlxMedia commented Jan 15, 2019

Issue description:

When updating from 3.0.33 to 3.0.35.3 the color field breaks inside of a repeater.

With the color field set to empty as default:

  • The field auto-sets to #ffffff even though it should be set to nothing
  • When you select a color in the color control it changes, but when you try to empty the field it doesn't reload and the color stays
  • The color field says "Hex Value" in the color field when nothing is set
  • When saving all repeater color items ends up with #ffffff as set color

Version used:

Version 3.0.35.3

Code to reproduce the issue (config + field(s))

I've emailed you the theme and code where you can test it. If you need any other information, please tell.

aristath added a commit that referenced this issue Jan 15, 2019
@aristath
Copy link
Contributor

The field auto-sets to #ffffff even though it should be set to nothing

fixed

The color field says "Hex Value" in the color field when nothing is set

fixed

When saving all repeater color items ends up with #ffffff as set color

fixed

When you select a color in the color control it changes, but when you try to empty the field it doesn't reload and the color stays

This will be an issue. Unfortunately I can't fix this with the current repeater structure, this will have to wait for the repeater rewrite - at which point it will be automatically fixed

@AlxMedia
Copy link
Contributor Author

AlxMedia commented Jan 15, 2019

Nice! Well the last one isn't that big of a deal as long as the other ones are fixed :-) When do you think this fixed version will be released? Should I wait for it or simply apply the fixes you've done for now?

Edit: Updated and tested the code with your fix and it works. Thanks.

@aristath
Copy link
Contributor

When do you think this fixed version will be released?

v3.0.36 contains a complete rewrite of the postMessage module. I've been working on it for about a year and I believe it's OK. If Kirki were not so popular probably wouldn't hesitate to release it right now, however I think I'll leave it in the develop branch for at least another week, see if any theme developers report any bugs etc with the new implementation 👍

@AlxMedia
Copy link
Contributor Author

Awesome 👍

@mapsteps
Copy link
Contributor

Hello and thank you for reporting this issue.

We are closing most open GitHub issues with the release of Kirki 4 to start fresh with this major release.

If you are still running into issues after you have tested your theme with Kirki 4, please let us know so we can reopen the issue.

Please note that Kirki 3 is no longer actively supported. Moving forward, we will only provide support the very latest version of Kirki.

Thank you for your understanding.

Best,
David

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants