Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make constructors const #388

Closed
Pratyush opened this issue Feb 9, 2022 · 1 comment · Fixed by #437
Closed

Make constructors const #388

Pratyush opened this issue Feb 9, 2022 · 1 comment · Fixed by #437
Labels
D-easy Difficulty: easy T-feature Type: new features T-refactor Type: cleanup/refactor

Comments

@Pratyush
Copy link
Member

Pratyush commented Feb 9, 2022 •
edited
Loading

Right now, when a struct has a trait bound (e.g. struct QuadExtField<P: QuadExtConfig>, we cannot make inherent impl methods const due to the trait bound. Once rust-lang/rust#93827 lands, we should change as many methods as possible to be const. When this is done for the new constructors, this can help us get rid of the QuadExt and CubicExt macros that were added in #379.
@Pratyush Pratyush assigned Pratyush and unassigned Pratyush Feb 9, 2022
@Pratyush Pratyush added D-easy Difficulty: easy T-feature Type: new features T-refactor Type: cleanup/refactor labels Feb 9, 2022
@mmagician
Copy link
Member

Closed in #437

@Pratyush Pratyush linked a pull request Sep 2, 2022 that will close this issue
Better const field and group initialization #437
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
D-easy Difficulty: easy T-feature Type: new features T-refactor Type: cleanup/refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Better const field and group initialization arkworks-rs/algebra
2 participants
@Pratyush @mmagician