Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"An Improved Version of Bridson's Algorithm" is incorrect #8

Open
bhickey opened this issue Jan 3, 2022 · 1 comment
Open

"An Improved Version of Bridson's Algorithm" is incorrect #8

bhickey opened this issue Jan 3, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@bhickey
Copy link

bhickey commented Jan 3, 2022

The algorithm described in Extreme Learning is incorrect: it does not generate blue noise.

Blue Noise is uniform in high frequency with no low frequency component. While the blog post claims that we need not sample the annulus uniformly, the post provides no justification for this claim. By sampling non-uniformly, the algorithm preferentially generates samples that are (r + epsilon) units apart at the expense of the interval (r + epsilon,2r). This is trading correctness for speed.

@arlyon arlyon added the enhancement New feature or request label Jan 4, 2022
@arlyon
Copy link
Owner

arlyon commented Jan 4, 2022

Hi! Thanks for your interest in this library.

Yes you are right. Thanks for raising this. This library was created for the purposes of game development and the dramatic speedup that comes with the loss of correctness was deemed a fair tradeoff.

That said, I am open to accepting a PR that adds a strategy for correct blue noise—if you would like to include it—so I will mark this as an enhancement. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants