Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Accept header for aop-prometheus endpoint causes error response #44

Open
osoriano opened this issue Mar 2, 2022 · 3 comments
Open

Comments

@osoriano
Copy link

osoriano commented Mar 2, 2022

Without any Accept header, the aop-prometheus endpoint returns a successful response

orca> wget -S http://localhost:8083/aop-prometheus
Connecting to localhost:8083 ([::1]:8083)
  HTTP/1.1 200
  Content-Type: text/plain; version=0.0.4;charset=utf-8
  Content-Length: 31287
  ...

When using the Accept a 406 error response is returned

orca> wget -S --header 'Accept: text/plain; version=0.0.4' http://localhost:8083/aop-prometheus
Connecting to localhost:8083 ([::1]:8083)
  HTTP/1.1 406
wget: server returned error: HTTP/1.1 406

The prometheus spring-boot WebEndpoint doesn't have this issue. Looking at the code for the aop endpoint, the Accept header may not have been implemented due to issues with plugins/WebEndpoint

@osoriano
Copy link
Author

osoriano commented Mar 3, 2022

The Prometheus scraper I'm using sends the Accept header, so I'll have to make some changes

@osoriano
Copy link
Author

osoriano commented Mar 4, 2022

Switching to the WebEndpoint got past the issue osoriano@cb15f3b

@osoriano
Copy link
Author

Still seeing 406 on clouddriver though. I wonder if this is related spinnaker/clouddriver#3846

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant