Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handling instantVerification in verifyPhoneNumber method #693

Closed
sollaattam opened this issue May 15, 2018 · 2 comments
Closed

handling instantVerification in verifyPhoneNumber method #693

sollaattam opened this issue May 15, 2018 · 2 comments

Comments

@sollaattam
Copy link

Hi,

I see that verifyPhoneNumber just returns 'instantVerification' as true incase of instantVerification/auto-verify scenarios in Android.
Can't it be changed such that it does sign-in and returns back 'idToken'? By this way, we can send this idToken to server and generate customIdToken after verifying idToken's value.

-Thanks
Ganesh

@soumak77
Copy link
Contributor

@sollaattam sure, PRs are welcome to add the desired functionality. You'll likely want to return an object which contains the properties verified, instant, and token so that all values can be checked if desired.

  • The value of verified would be a boolean indicating whether or not the phone number was verified.
  • The value of instant would be a boolean indicating whether or not the verification happened instantly.
  • The value of token would be a string containing the ID token

@soumak77
Copy link
Contributor

this has been fixed in v2.0.3 via #861

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants