Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open for design updates? #732

Closed
Tricked-dev opened this issue Apr 7, 2024 · 3 comments
Closed

open for design updates? #732

Tricked-dev opened this issue Apr 7, 2024 · 3 comments

Comments

@Tricked-dev
Copy link
Contributor

Hi i made a couple of changes to make the darkmode ui look a bit better and was wondering if these changes would be welcomed to be pr'ed to the main branch? (it wouild require a bit of refactoring on my part cause of the way ive done it currently but would be happy to)

image

@arp242
Copy link
Owner

arp242 commented Apr 7, 2024

Yes! I've been getting people to actually design a dark more for ages.

All dark modes look unreadable to me – if a site has dark mode only then I either don't read/use it or fiddle with the CSS – for whatever reason my eyes just can't deal with it. So I can't really design that in any meaningful way. I already did all the technical stuff for it, just need someone to fill in some reasonable colours. See: #586 (comment)

@Tricked-dev
Copy link
Contributor Author

do you like the blues? i feel like they are more readable than the purple in darkmode

@arp242
Copy link
Owner

arp242 commented Apr 7, 2024

Sure, I'm fine with whatever – like I said, it all looks bad to me 🤷

@arp242 arp242 closed this as completed Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants