Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Actions improvements, Revert karma config, and add KotestProjectConfig #2904

Merged
merged 14 commits into from
Jan 27, 2023

Conversation

nomisRev
Copy link
Member

@nomisRev nomisRev commented Jan 25, 2023

In #2874 we increased property test iterations from 250 to 1000 here.

We then later had to add karma.config to fix timeouts on JS platform, since running 1000 iterations was taking so long that the browsers considered the tests timing out.

This PR reverts the karma.config, and uses KotestProjectConfig to set iterations back to 250. This was done because I noticed some flakiness issues on JVM using 1000 iterations on Github Actions 😞

@nomisRev nomisRev requested review from serras and a team January 25, 2023 15:49
@nomisRev
Copy link
Member Author

nomisRev commented Jan 25, 2023

check is still flaky with this change 😞

@serras Whenever I check the failed check task I see an enormous amount of log output related to classpath of Optics KSP tests. Do you know if this is something we can disable, or configure? Or is this out of our control? All the output seems unnecessary to always be logged, it seems like INFO or DEBUG level logging.

@serras
Copy link
Member

serras commented Jan 25, 2023

It's printed by us in this line. I'm happy if you just comment it out, it adds no value outside of debugging environments.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 26, 2023

Kover Report

Total Project Coverage 42.20%

@nomisRev nomisRev requested a review from a team January 26, 2023 13:03
Copy link
Member

@JavierSegoviaCordoba JavierSegoviaCordoba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would only change the jvmTest part

@nomisRev nomisRev changed the title Revert karma config, and add KotestProjectConfig Github Actions improvements, Revert karma config, and add KotestProjectConfig Jan 27, 2023
@nomisRev nomisRev merged commit 09384c1 into main Jan 27, 2023
@nomisRev nomisRev deleted the sv-revert-karma-config-add-kotest-config branch January 27, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants