-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github Actions improvements, Revert karma config, and add KotestProjectConfig #2904
Conversation
@serras Whenever I check the failed |
It's printed by us in this line. I'm happy if you just comment it out, it adds no value outside of debugging environments. |
Kover Report
|
This reverts commit 1d0dce6.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would only change the jvmTest
part
In #2874 we increased property test iterations from
250
to1000
here.We then later had to add
karma.config
to fix timeouts on JS platform, since running 1000 iterations was taking so long that the browsers considered the tests timing out.This PR reverts the
karma.config
, and usesKotestProjectConfig
to set iterations back to250
. This was done because I noticed some flakiness issues on JVM using1000
iterations on Github Actions 😞