Add partitionMap to Iterable (#3001) #3004
Conversation
| * <!--- KNIT example-iterable-20.kt --> | ||
| * <!--- TEST lines.isEmpty() --> | ||
| */ | ||
| public inline fun <T, A, B> Iterable<T>.partitionMap(f: (T) -> Either<A, B>): Pair<List<A>, List<B>> { |
There was a problem hiding this comment.
Wondering about the name 🤔 I asked chat-gpt 😁 It suggested seperateMap, it would be more aligned with seperateEither. What do you think?
There was a problem hiding this comment.
@nomisRev I didn't have a particularly strong opinion on the naming of this function, and thought it would be fine as it is in Scala's partitionMap.
As you mention in the Kotlin slack, I prefer to assume that Iterable<Either<A,B>>.separateEither overloads this. I would change it that way.
There was a problem hiding this comment.
I have no strong opinion towards any names, but I just feel that they should be aligned. I somehow missed that Kotlin Std already has partition.
Haskell names seperateEither as partitionEither so in that case partitionEither and partitionMap would make sense. I invited some other reviewers to the PR.
Implementation for #3001