Standardize styling of the various search icons #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -161,6 +169,22 @@ class AccessMemberCardFragment : BaseViewModelFragment<AccessMemberCardViewModel | |||
| .disposedBy(disposeBag) | |||
| } | |||
|
|
|||
| override fun setupNavigationBindings(viewModel: AccessMemberCardViewModel) { | |||
| super.setupNavigationBindings(viewModel) | |||
| viewModel.navigateTo | |||
There was a problem hiding this comment.
Identical blocks of code found in 4 locations. Consider refactoring.
Cliabhach
force-pushed
the
pc-standardize-search-button-execution
branch
from
5681758 to
6e8eafe
Compare
|
@caguilar187 If you have a moment today, I'd appreciate your eyes on this. It shouldn't be terribly controversial. |
caguilar187
approved these changes
Oct 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not significantly modify the layout of any such
ImageView; note that this work is primarily intended to lay the groundwork for tasks related to #298 (right now, PR #291 and PR #299 are the best examples of that).