Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package release with recent fixes #17

Open
infotexture opened this issue Dec 25, 2013 · 7 comments
Open

Package release with recent fixes #17

infotexture opened this issue Dec 25, 2013 · 7 comments

Comments

@infotexture
Copy link
Contributor

Please package a new release that includes recent fixes.

The last packaged release is v0.2-beta3, but there have been several commits since then, such as 2754ff0 & c3b41a2, which fix #7.

Tried building from source, but resulting .app file crashes at launch.

Would be nice to have a new binary that includes these and other fixes.

@artynusov
Copy link
Owner

Built latest version based on master: https://github.com/SPlyer/MacTimeLog/releases/download/v0.3-alpha/MacTimeLog.v0.3-alpha.zip

If it crashes again please send me log file (~/Library/Logs/MacTimeLog/MacTimeLog.log)

@infotexture
Copy link
Contributor Author

Hi Artem,

Thanks for providing this. It doesn't crash on launch, but I did notice a few things:

  1. The new version overwrote my settings on the Preferences > General tab with default values for Working day starts at, Log edit command, etc.
  2. The numeric entry fields under Preferences > Notifications don't respond to keyboard input (clicking arrows with the mouse works).
  3. In Report view date fields should default to current date (always show?) #7, I wrote:

    Consider also showing date fields (read only?) when other Period options are selected.
    This is helpful to understand which time range is displayed for options such as Current Week, Current Month, etc., but only if the values are updated to reflect the selection period. They currently show today's date, regardless of the selected Period.

@infotexture
Copy link
Contributor Author

The new version did crash when my launch script tried to activate the app via AppleScript:

tell application "MacTimeLog" to activate

The log file suggests the system tried to launch the version I built from source a few days ago (instead of your new version, which lives at /Applications/Utilities/MacTimeLog.app):

[2013-12-30 13:00:05,002] [ERROR] [mactimelog] RuntimeError: 
  ~/Library/Application Support/MacTimeLog/projects is locked.
  There is probably a Durus storage server (or a client)
  using it.

File "~/.../MacTimeLog/dist/MacTimeLog.app/Contents/Resources/__boot__.py", line 316, in <module>
  File "~/.../MacTimeLog/dist/MacTimeLog.app/Contents/Resources/__boot__.py", line 311, in _run
  File "~/.../MacTimeLog/dist/MacTimeLog.app/Contents/Resources/main.py", line 29, in <module>
  File "gui/delegates/app_delegate.pyc", line 4, in <module>
  File "tasks/projects.pyc", line 67, in <module>
  File "tasks/projects.pyc", line 22, in __init__
  File "~/.../MacTimeLog/dist/MacTimeLog.app/Contents/Resources/lib/python2.7/durus/file_storage.py", line 89, in __init__

How do I "unlock" the projects file & make sure the right version of the app is launched?

@infotexture
Copy link
Contributor Author

I fixed the crash problem by deleting the manually built version from the dist/ folder.

Now my launch script activates the 0.3-alpha version correctly.

@artynusov
Copy link
Owner

Hi Roger,

  1. I'm aware of that. I'm in process of getting rid of durus completely, settings was moved to ini format, probably I'll do a migration script that will convert settings from durus to ini.
  2. Hm, did it work with arrows before ?
  3. Fixed in the new release

@infotexture
Copy link
Contributor Author

  1. “settings was moved to ini format”
    Nice. So editing ~/Library/Application Support/MacTimeLog/user_prefs.ini changes settings.
    Would be good if this could include log file location & date formats (see Make more things configurable in Preferences #3).
  2. No, just checked. Wasn't possible to type new values in old version either. Only works with mouse.
  3. Looks like the From and To values are reversed in alpha2.
    If I set the Period to Current Month, it shows From 2014-01-08 (which is tomorrow) To 2014-01-01.
    See Fix custom date field association (To/From) in Reports view #18.

@artynusov
Copy link
Owner

  1. It's pretty easy to make log location editable in settings file, as for date formats, it's a bit trickier, because it'd require to change date format in log file as well.
  2. Thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants