Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cibuildwheel: Add macOS arm64 support #7727

Draft
wants to merge 1 commit into
base: RC_2_0
Choose a base branch
from

Conversation

xavier2k6
Copy link
Contributor

@xavier2k6 xavier2k6 commented Aug 9, 2024

Closes #7308.
Closes #7536.
Closes #7650.
Closes #7683.
Closes #7729.

@xavier2k6
Copy link
Contributor Author

Note/Review: pypa/cibuildwheel#1926 (comment)

@xavier2k6 xavier2k6 force-pushed the wheel_macos_arm64 branch 3 times, most recently from b8a644f to 2519f14 Compare August 9, 2024 16:42
@xavier2k6
Copy link
Contributor Author

@qstokkink Can you give the created wheels a test?

@xavier2k6
Copy link
Contributor Author

@xavier2k6 xavier2k6 force-pushed the wheel_macos_arm64 branch 2 times, most recently from 6934d07 to bc511c5 Compare August 9, 2024 21:49
@qstokkink
Copy link

@qstokkink Can you give the created wheels a test?

Works on my machine. 👍

On behalf of the Tribler team, I would like to request you to keep {"os": "macos-12", "CIBW_BUILD": "cp39-*", "CIBW_ARCHS": "x86_64"} in the workflow dispatch matrix though.

@xavier2k6
Copy link
Contributor Author

@qstokkink

  1. I've added macOS-12/x86_x64 architecture with Python 3.9 to pull_request matrix for testing purposes (this can probably be removed again, once you've tested)
  2. Have included macOS-12/x86_x64 architecture with Python * to workflow dispatch unless of course You/Tribler team only want Python 3.9/x86_x64 on macOS-12??

@xavier2k6 xavier2k6 force-pushed the wheel_macos_arm64 branch 2 times, most recently from fc34c3a to c8add64 Compare August 10, 2024 18:16
@xavier2k6 xavier2k6 marked this pull request as ready for review August 11, 2024 19:56
@qstokkink
Copy link

qstokkink commented Aug 12, 2024

Thanks 👍 and, "correct" to 2: I copied the wrong string.

@xavier2k6
Copy link
Contributor Author

@qstokkink Just so the Tribler team are aware macOS-12 images are considered Deprecated & will be Removed by end of year!
See: actions/runner-images#9255 or screenshot below.


300882082-ac6ef1f1-8e18-4af1-a97f-d38cf82885df

@qstokkink
Copy link

🤔 that's sad. It would be nice to get a PyPI release before that gets killed though.

@qstokkink
Copy link

@xavier2k6 considering the other closed issues, it looks like you can add #7729 to your "Closes" list.

@xavier2k6
Copy link
Contributor Author

manylinux2014 image may be dropped in a upcoming PR too by "cibuildwheel" repo., so may need to change to manylinux_2_28 but this may also drop older python versions but that is already on the cards by "cibuildwheel" repo.

@xavier2k6
Copy link
Contributor Author

@arvidn Regarding to OpenSSL 1.1.1 End Of Life


  1. Should wheels for Python <3.10 be dropped?

  1. What minimum OpenSSL 3.x.x version should be declared for below?

export OPENSSL_ROOT=openssl-1.1.1l
export OPENSSL_HASH=0b7a3e5e59c34827fe0c3a74b7ec8baef302b98fa80088d7f9153aa16fa76bd1


  1. FORTIFY_SOURCE may be bumped to 3 if images are newer/all conditions/requirements are met.

MANYLINUX_CPPFLAGS="-Wdate-time -D_FORTIFY_SOURCE=2"

@xavier2k6 xavier2k6 force-pushed the wheel_macos_arm64 branch 9 times, most recently from 62a6cbe to 6069880 Compare August 28, 2024 15:09
@DjLegolas
Copy link

@xavier2k6 please re-add MacOS to the pull request matrix (MATRIX_PULL_REQUEST) as the libtorrent must be also validated on it.

@xavier2k6
Copy link
Contributor Author

@DjLegolas I only removed macOS from pull request matrix to reduce building time while I test as I know they work.

When I am done, they will be re-added - don't worry.

@xavier2k6 xavier2k6 marked this pull request as draft September 6, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants