From 86b01975dc5c0bb439da9872b6027032ca319bdf Mon Sep 17 00:00:00 2001 From: Andrew Morton Date: Wed, 24 Sep 2014 15:37:37 +0400 Subject: [PATCH] kernel-add-support-for-gcc-5-checkpatch-fixes WARNING: line over 80 characters #25: FILE: include/linux/compiler-gcc5.h:2: +#error "Please don't include directly, include instead." WARNING: please, no space before tabs #29: FILE: include/linux/compiler-gcc5.h:6: +#define __must_check ^I^I__attribute__((warn_unused_result))$ ERROR: space required after that ',' (ctx:VxV) #30: FILE: include/linux/compiler-gcc5.h:7: +#define __compiler_offsetof(a,b) __builtin_offsetof(a,b) ^ ERROR: space required after that ',' (ctx:VxV) #30: FILE: include/linux/compiler-gcc5.h:7: +#define __compiler_offsetof(a,b) __builtin_offsetof(a,b) ^ total: 2 errors, 2 warnings, 66 lines checked ./patches/kernel-add-support-for-gcc-5.patch has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Sasha Levin Signed-off-by: Andrew Morton --- include/linux/compiler-gcc5.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/linux/compiler-gcc5.h b/include/linux/compiler-gcc5.h index b989d55bd363c0..cdd1cc202d51ef 100644 --- a/include/linux/compiler-gcc5.h +++ b/include/linux/compiler-gcc5.h @@ -2,9 +2,9 @@ #error "Please don't include directly, include instead." #endif -#define __used __attribute__((__used__)) -#define __must_check __attribute__((warn_unused_result)) -#define __compiler_offsetof(a,b) __builtin_offsetof(a,b) +#define __used __attribute__((__used__)) +#define __must_check __attribute__((warn_unused_result)) +#define __compiler_offsetof(a, b) __builtin_offsetof(a, b) /* Mark functions as cold. gcc will assume any path leading to a call to them will be unlikely. This means a lot of manual unlikely()s