Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add login without password, and some rewrite #361

Merged
merged 30 commits into from
Mar 14, 2022
Merged

feat: add login without password, and some rewrite #361

merged 30 commits into from
Mar 14, 2022

Conversation

asbiin
Copy link
Owner

@asbiin asbiin commented Feb 15, 2022

This adds the ability to login a user with their email and registered webauthn key.
It also adds a rate limiter.

This fix #360
This fix #332

BREAKING CHANGE: options (webauthn.auth.options and webauthn.store.options) routes are now POST. GET routes are reserved for the views (webauthn.login and webauthn.create). webauthn.auth and webauthn.store routes must send data flatten. See details in https://github.com/asbiin/laravel-webauthn/blob/main/docs/migration-v2-to-v3.md .

  • LoginViewResponse contract has now a setPublicKey method
  • RegisterSuccessResponse contract has now a setWebauthnKey method
  • RegisterViewResponse contract has now a setPublicKey method
  • Webauthn::login() now takes 1 argument for $user: login(\Illuminate\Contracts\Auth\Authenticatable $user)

@asbiin asbiin changed the base branch from main to beta February 26, 2022 09:47
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

90.2% 90.2% Coverage
0.0% 0.0% Duplication

@asbiin asbiin merged commit 6778707 into beta Mar 14, 2022
@asbiin asbiin deleted the 20220115-v3 branch March 14, 2022 21:22
@github-actions
Copy link

🎉 This PR is included in version 3.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

passwordless login Modify routes
2 participants