fix: ensure asdf-plugin-manager works in expected worktree #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
airtonix
commented
Jun 18, 2024
airtonix
commented
Jun 18, 2024
airtonix
commented
Jun 18, 2024
airtonix
commented
Jun 19, 2024
|
@aabouzaid, Any idea, when this will be merged.? we are also facing this issue if we aren't using the latest commit ref for the plugins. Also I have tested this fix by downloading the script and it helps to resolve the issue. |
aabouzaid
force-pushed
the
fix/55-dont-modify-repo-in-pwd
branch
from
2aa6b3e
to
c79a3a3
Compare
aabouzaid
changed the title
aabouzaid
changed the title
aabouzaid
force-pushed
the
fix/55-dont-modify-repo-in-pwd
branch
from
c79a3a3
to
eb39134
Compare
aabouzaid
force-pushed
the
fix/55-dont-modify-repo-in-pwd
branch
from
eb39134
to
7092ab6
Compare
|
I've fixed the issue, which will be included in the next release. |
airtonix
commented
Sep 24, 2024
Comment on lines
79
to
+81
| plugin_name="${1}" | ||
| plugin_ref="${2}" | ||
| git --git-dir "${PLUGINS_REPOS_DIR}/${plugin_name}/.git" checkout "${plugin_ref}" -q | ||
| git_dir="${PLUGINS_REPOS_DIR}/${plugin_name}" |
There was a problem hiding this comment.
btw removing local now means you're reassigning a global variable, which these are not. just fyi.
There was a problem hiding this comment.
It's only a problem if another global var has the same name.
But in general, I will review all functions vars and make them local to avoid any issues in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #55
--git-dirdoesn't work as by itself, so also include--worktree