Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for upgrading outdated versions #343

Closed
vraravam opened this issue Jul 31, 2018 · 4 comments
Closed

Support for upgrading outdated versions #343

vraravam opened this issue Jul 31, 2018 · 4 comments

Comments

@vraravam
Copy link

This is more of a feature request. If/when issue #240 is completed, we can add support for querying the list-all functionality for that plugin, and then compare with the versions of the language that is currently installed/applicable in the current folder. This can be exposed via asdf outdated [plugin-name].

@Stratus3D
Copy link
Member

I'm open to contributions for this command, but I'm not sure when it would be used. asdf should work fine even when installed versions are no longer available via the plugin. And right now this functionality could be achieved with a simple shell script. All you'd need to do is capture the output of asdf list-all <tool> and asdf list <tool> and find the versions only present in the asdf list command.

This also doesn't depend on #240.

@vraravam vraravam changed the title Support for outdated versions Support for upgrading outdated versions Sep 19, 2018
@vraravam
Copy link
Author

@Stratus3D - Do you think there's a difference in upgrade vs update in the context of asdf. IF so, then I agree that this could be construed to be different from #240. I have reworded this request title - in case it clarifies the intent.
Also, I was looking for a way to update to the latest version allowed by semantic versioning rules (not the inclusive vs exclusive, ~, etc) - but more in the context of "what has the user tried to lock based on the .tool-versions file, and for that, in the case of non-standard plugins, was where I was thinking that #240 is actually a dependency.
As an example, if the .tool-versions file has ruby locked to 2.5, and the plugin's list-all functionality lists 2.5.1, my feature request can then update from 2.5.0 (which is installed) to 2.5.1 which is now available. Hope that makes it clearer?

@Stratus3D
Copy link
Member

In that case I think this goes along with #352. We don't want asdf to have to be concerned with versioning schemes. See my comment on that issue for the reasons why: #352 (comment). If this is functionality that's needed it will need to be handled by the plugin, since it's the plugin's responsibility to deal with comparison and manipulation of tool versions.

@Stratus3D Stratus3D reopened this Sep 19, 2018
@vraravam
Copy link
Author

Thanks @Stratus3D - yes, i think #352 is very close to what I was thinking. I'll close this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants