-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is there a way to freeze the version of the plugins themselves? #588
Comments
You are correct. We don't currently support this. We just clone the plugin and checkout the latest commit on the master branch.
Possibly. Most of the time it is not that important as plugin changes are seldom backwards compatible, so for everyday local development it's just not needed. For builds and other automated tools I can see how something like this could be useful. I'd be in favor of adding support for this, though it should probably be optional so as to not introduce any additional friction to the plugin-adding process. Note that the core team doesn't have time for this, so the best way to make this happen is to implement it yourself (PRs welcome).
Yes you could do that. I can't promise the internals won't change at some point though. Plugins are simply git repositories in specific directories so it easy enough to do and shouldn't cause any problems for asdf. |
#166 is very similar to this issue. |
@Stratus3D thanks for the feedback. Feel free to close for now - if I find the time later this year, I will work on an optional "branch/commit" option! |
Closing this issue. Any future discussion should take place on #166. |
First, thanks for
asdf
! Great tool!I'm typically using
asdf
inside automated build tools (e.g. docker build chains), like this:I would like to be able to freeze the version (as a commit) of each plugin, in order to 1) make builds more deterministic and 2) allow for security reviews before upgrading (like this can be done for other tooling, e.g.
bundler
in Ruby,hex
in Elixir, or even ansible).I'm only discovered the code of
asdf
and I believe the plugin-add command won't be able to clone a specific commit of each plugin.Is that a feature that would be valued by other users of the
asdf
project?Alternatively, is just cloning myself at the right place the way to go to support that, if I don't modify
asdf
?Thanks for your insights!
The text was updated successfully, but these errors were encountered: