From e68c2b05e1ef6fbc2206b089a637334569852cd1 Mon Sep 17 00:00:00 2001 From: Joe DiPol Date: Tue, 30 Mar 2021 16:13:59 -0700 Subject: [PATCH] Add plugin to spotbugs-maven-plugin (#2878) * Add findsecbugs-plugin to spotbugs-maven-plugin --- common/configurable/etc/spotbugs/exclude.xml | 39 ++++++++++++ common/configurable/pom.xml | 4 ++ config/config-mp/etc/spotbugs/exclude.xml | 42 +++++++++++++ config/config-mp/pom.xml | 4 ++ config/config/etc/spotbugs/exclude.xml | 52 +++++++++++++++- config/encryption/etc/spotbugs/exclude.xml | 61 +++++++++++++++++++ config/encryption/pom.xml | 4 ++ config/yaml/etc/spotbugs/exclude.xml | 32 ++++++++++ config/yaml/pom.xml | 4 ++ dbclient/jdbc/etc/spotbugs/exclude.xml | 31 +++++++++- fault-tolerance/etc/spotbugs/exclude.xml | 31 ++++++++++ fault-tolerance/pom.xml | 4 ++ grpc/core/etc/spotbugs/exclude.xml | 32 ++++++++++ grpc/core/pom.xml | 4 ++ grpc/server/etc/spotbugs/exclude.xml | 31 ++++++++++ grpc/server/pom.xml | 4 ++ health/health-checks/etc/spotbugs/exclude.xml | 32 ++++++++++ health/health-checks/pom.xml | 4 ++ .../cdi/jpa-cdi/etc/spotbugs/exclude.xml | 28 ++++++++- .../etc/spotbugs/exclude.xml | 32 ++++++++++ .../cdi/oci-objectstorage-cdi/pom.xml | 1 + logging/jul/etc/spotbugs/exclude.xml | 32 ++++++++++ logging/jul/pom.xml | 4 ++ media/common/etc/spotbugs/exclude.xml | 32 ++++++++++ media/common/pom.xml | 4 ++ metrics/metrics/etc/spotbugs/exclude.xml | 11 +++- .../graphql/server/etc/spotbugs/exclude.xml | 44 +++++++++++++ microprofile/graphql/server/pom.xml | 5 ++ .../jwt-auth/etc/spotbugs/exclude.xml | 22 ++++++- openapi/etc/spotbugs/exclude.xml | 38 ++++++++++++ openapi/pom.xml | 1 + pom.xml | 8 +++ .../abac/policy-el/etc/spotbugs/exclude.xml | 32 ++++++++++ security/abac/policy-el/pom.xml | 4 ++ .../http-auth/etc/spotbugs/exclude.xml | 39 ++++++++++++ security/providers/http-auth/pom.xml | 4 ++ webclient/webclient/etc/spotbugs/exclude.xml | 31 ++++++++++ webclient/webclient/pom.xml | 4 ++ .../static-content/etc/spotbugs/exclude.xml | 50 +++++++++++++++ webserver/static-content/pom.xml | 4 ++ .../test-support/etc/spotbugs/exclude.xml | 38 ++++++++++++ webserver/test-support/pom.xml | 4 ++ webserver/webserver/etc/spotbugs/exclude.xml | 34 ++++++++++- 43 files changed, 914 insertions(+), 7 deletions(-) create mode 100644 common/configurable/etc/spotbugs/exclude.xml create mode 100644 config/config-mp/etc/spotbugs/exclude.xml create mode 100644 config/encryption/etc/spotbugs/exclude.xml create mode 100644 config/yaml/etc/spotbugs/exclude.xml create mode 100644 fault-tolerance/etc/spotbugs/exclude.xml create mode 100644 grpc/core/etc/spotbugs/exclude.xml create mode 100644 grpc/server/etc/spotbugs/exclude.xml create mode 100644 health/health-checks/etc/spotbugs/exclude.xml create mode 100644 integrations/cdi/oci-objectstorage-cdi/etc/spotbugs/exclude.xml create mode 100644 logging/jul/etc/spotbugs/exclude.xml create mode 100644 media/common/etc/spotbugs/exclude.xml create mode 100644 microprofile/graphql/server/etc/spotbugs/exclude.xml create mode 100644 openapi/etc/spotbugs/exclude.xml create mode 100644 security/abac/policy-el/etc/spotbugs/exclude.xml create mode 100644 security/providers/http-auth/etc/spotbugs/exclude.xml create mode 100644 webclient/webclient/etc/spotbugs/exclude.xml create mode 100644 webserver/static-content/etc/spotbugs/exclude.xml create mode 100644 webserver/test-support/etc/spotbugs/exclude.xml diff --git a/common/configurable/etc/spotbugs/exclude.xml b/common/configurable/etc/spotbugs/exclude.xml new file mode 100644 index 00000000000..b65246ca15b --- /dev/null +++ b/common/configurable/etc/spotbugs/exclude.xml @@ -0,0 +1,39 @@ + + + + + + + + + + + + + + + + + + + + diff --git a/common/configurable/pom.xml b/common/configurable/pom.xml index 463429baab4..a9077b03d08 100644 --- a/common/configurable/pom.xml +++ b/common/configurable/pom.xml @@ -29,6 +29,10 @@ Helidon Common Configurable helidon-common-configurable + + etc/spotbugs/exclude.xml + + io.helidon.common diff --git a/config/config-mp/etc/spotbugs/exclude.xml b/config/config-mp/etc/spotbugs/exclude.xml new file mode 100644 index 00000000000..d1a3085bfe7 --- /dev/null +++ b/config/config-mp/etc/spotbugs/exclude.xml @@ -0,0 +1,42 @@ + + + + + + + + + + + + + + + + + + + + + + + diff --git a/config/config-mp/pom.xml b/config/config-mp/pom.xml index 4753ebb07aa..8ee12c2371c 100644 --- a/config/config-mp/pom.xml +++ b/config/config-mp/pom.xml @@ -29,6 +29,10 @@ Helidon Config MP Core of the implementation of MicroProfile Config specification + + etc/spotbugs/exclude.xml + + jakarta.annotation diff --git a/config/config/etc/spotbugs/exclude.xml b/config/config/etc/spotbugs/exclude.xml index efc3b31bd1c..c2b40fe9698 100644 --- a/config/config/etc/spotbugs/exclude.xml +++ b/config/config/etc/spotbugs/exclude.xml @@ -1,7 +1,7 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/config/encryption/etc/spotbugs/exclude.xml b/config/encryption/etc/spotbugs/exclude.xml new file mode 100644 index 00000000000..39e636290be --- /dev/null +++ b/config/encryption/etc/spotbugs/exclude.xml @@ -0,0 +1,61 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/config/encryption/pom.xml b/config/encryption/pom.xml index 5c77b1abf21..735faccf2fe 100644 --- a/config/encryption/pom.xml +++ b/config/encryption/pom.xml @@ -34,6 +34,10 @@ store them in config files. + + etc/spotbugs/exclude.xml + + io.helidon.config diff --git a/config/yaml/etc/spotbugs/exclude.xml b/config/yaml/etc/spotbugs/exclude.xml new file mode 100644 index 00000000000..9ec9c5b0882 --- /dev/null +++ b/config/yaml/etc/spotbugs/exclude.xml @@ -0,0 +1,32 @@ + + + + + + + + + + + + + diff --git a/config/yaml/pom.xml b/config/yaml/pom.xml index 443e85c6360..50cd94ffcb9 100644 --- a/config/yaml/pom.xml +++ b/config/yaml/pom.xml @@ -33,6 +33,10 @@ YAML Parser implementation. + + etc/spotbugs/exclude.xml + + io.helidon.config diff --git a/dbclient/jdbc/etc/spotbugs/exclude.xml b/dbclient/jdbc/etc/spotbugs/exclude.xml index 0e0f5ff8e62..905b9d4f39f 100644 --- a/dbclient/jdbc/etc/spotbugs/exclude.xml +++ b/dbclient/jdbc/etc/spotbugs/exclude.xml @@ -1,6 +1,6 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/fault-tolerance/etc/spotbugs/exclude.xml b/fault-tolerance/etc/spotbugs/exclude.xml new file mode 100644 index 00000000000..c939014cd3b --- /dev/null +++ b/fault-tolerance/etc/spotbugs/exclude.xml @@ -0,0 +1,31 @@ + + + + + + + + + + + + diff --git a/fault-tolerance/pom.xml b/fault-tolerance/pom.xml index ca34d53f4ac..3362e8ac586 100644 --- a/fault-tolerance/pom.xml +++ b/fault-tolerance/pom.xml @@ -29,6 +29,10 @@ helidon-fault-tolerance Helidon Fault Tolerance + + etc/spotbugs/exclude.xml + + io.helidon.config diff --git a/grpc/core/etc/spotbugs/exclude.xml b/grpc/core/etc/spotbugs/exclude.xml new file mode 100644 index 00000000000..e2aa16c7760 --- /dev/null +++ b/grpc/core/etc/spotbugs/exclude.xml @@ -0,0 +1,32 @@ + + + + + + + + + + + + + diff --git a/grpc/core/pom.xml b/grpc/core/pom.xml index 00697891d9e..f751a9669f8 100644 --- a/grpc/core/pom.xml +++ b/grpc/core/pom.xml @@ -31,6 +31,10 @@ helidon-grpc-core Helidon gRPC Core + + etc/spotbugs/exclude.xml + + io.helidon.common diff --git a/grpc/server/etc/spotbugs/exclude.xml b/grpc/server/etc/spotbugs/exclude.xml new file mode 100644 index 00000000000..37b720d88de --- /dev/null +++ b/grpc/server/etc/spotbugs/exclude.xml @@ -0,0 +1,31 @@ + + + + + + + + + + + + diff --git a/grpc/server/pom.xml b/grpc/server/pom.xml index 7dcfa2d7ca8..bd6ce2a2093 100644 --- a/grpc/server/pom.xml +++ b/grpc/server/pom.xml @@ -31,6 +31,10 @@ helidon-grpc-server Helidon gRPC Server + + etc/spotbugs/exclude.xml + + io.helidon.grpc diff --git a/health/health-checks/etc/spotbugs/exclude.xml b/health/health-checks/etc/spotbugs/exclude.xml new file mode 100644 index 00000000000..69f134201f8 --- /dev/null +++ b/health/health-checks/etc/spotbugs/exclude.xml @@ -0,0 +1,32 @@ + + + + + + + + + + + + + diff --git a/health/health-checks/pom.xml b/health/health-checks/pom.xml index b60ce5dc533..ed8600dd602 100644 --- a/health/health-checks/pom.xml +++ b/health/health-checks/pom.xml @@ -32,6 +32,10 @@ Microprofile Health implementation - health checks supported OOTB + + etc/spotbugs/exclude.xml + + io.helidon.health diff --git a/integrations/cdi/jpa-cdi/etc/spotbugs/exclude.xml b/integrations/cdi/jpa-cdi/etc/spotbugs/exclude.xml index 19dfeefbd2e..e6dc73b7fb3 100644 --- a/integrations/cdi/jpa-cdi/etc/spotbugs/exclude.xml +++ b/integrations/cdi/jpa-cdi/etc/spotbugs/exclude.xml @@ -1,6 +1,6 @@ + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/integrations/cdi/oci-objectstorage-cdi/etc/spotbugs/exclude.xml b/integrations/cdi/oci-objectstorage-cdi/etc/spotbugs/exclude.xml new file mode 100644 index 00000000000..4b53e801a5e --- /dev/null +++ b/integrations/cdi/oci-objectstorage-cdi/etc/spotbugs/exclude.xml @@ -0,0 +1,32 @@ + + + + + + + + + + + + + diff --git a/integrations/cdi/oci-objectstorage-cdi/pom.xml b/integrations/cdi/oci-objectstorage-cdi/pom.xml index a2f7a2b08f0..bdc516f2767 100644 --- a/integrations/cdi/oci-objectstorage-cdi/pom.xml +++ b/integrations/cdi/oci-objectstorage-cdi/pom.xml @@ -34,6 +34,7 @@ + etc/spotbugs/exclude.xml diff --git a/logging/jul/etc/spotbugs/exclude.xml b/logging/jul/etc/spotbugs/exclude.xml new file mode 100644 index 00000000000..369f312280c --- /dev/null +++ b/logging/jul/etc/spotbugs/exclude.xml @@ -0,0 +1,32 @@ + + + + + + + + + + + + + diff --git a/logging/jul/pom.xml b/logging/jul/pom.xml index 9f995f803ca..247e3c2ccd5 100644 --- a/logging/jul/pom.xml +++ b/logging/jul/pom.xml @@ -27,6 +27,10 @@ helidon-logging-jul Helidon Java Util Logging Integration + + etc/spotbugs/exclude.xml + + io.helidon.common diff --git a/media/common/etc/spotbugs/exclude.xml b/media/common/etc/spotbugs/exclude.xml new file mode 100644 index 00000000000..30eb4b58d8d --- /dev/null +++ b/media/common/etc/spotbugs/exclude.xml @@ -0,0 +1,32 @@ + + + + + + + + + + + + + diff --git a/media/common/pom.xml b/media/common/pom.xml index 92a836efd60..ab055d67aca 100644 --- a/media/common/pom.xml +++ b/media/common/pom.xml @@ -28,6 +28,10 @@ helidon-media-common Helidon Media Common + + etc/spotbugs/exclude.xml + + io.helidon.common diff --git a/metrics/metrics/etc/spotbugs/exclude.xml b/metrics/metrics/etc/spotbugs/exclude.xml index 872fbd95709..a537726cb85 100644 --- a/metrics/metrics/etc/spotbugs/exclude.xml +++ b/metrics/metrics/etc/spotbugs/exclude.xml @@ -1,7 +1,7 @@ + + + + + diff --git a/microprofile/graphql/server/etc/spotbugs/exclude.xml b/microprofile/graphql/server/etc/spotbugs/exclude.xml new file mode 100644 index 00000000000..39893eda894 --- /dev/null +++ b/microprofile/graphql/server/etc/spotbugs/exclude.xml @@ -0,0 +1,44 @@ + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/microprofile/graphql/server/pom.xml b/microprofile/graphql/server/pom.xml index a534e7cd428..0e787ff0f7e 100644 --- a/microprofile/graphql/server/pom.xml +++ b/microprofile/graphql/server/pom.xml @@ -28,6 +28,11 @@ Helidon Microprofile GraphQL Server The Microprofile GraphQL Server implementation + + etc/spotbugs/exclude.xml + + + org.eclipse.microprofile.graphql diff --git a/microprofile/jwt-auth/etc/spotbugs/exclude.xml b/microprofile/jwt-auth/etc/spotbugs/exclude.xml index c4b8b3c5f81..99e23b09f56 100644 --- a/microprofile/jwt-auth/etc/spotbugs/exclude.xml +++ b/microprofile/jwt-auth/etc/spotbugs/exclude.xml @@ -1,7 +1,7 @@ + + + + + + + + + + + + + + + + + + + + diff --git a/openapi/etc/spotbugs/exclude.xml b/openapi/etc/spotbugs/exclude.xml new file mode 100644 index 00000000000..3fc7ea74d76 --- /dev/null +++ b/openapi/etc/spotbugs/exclude.xml @@ -0,0 +1,38 @@ + + + + + + + + + + + + + + + + + + + diff --git a/openapi/pom.xml b/openapi/pom.xml index d3cf5ffeca1..abad181a4bc 100644 --- a/openapi/pom.xml +++ b/openapi/pom.xml @@ -38,6 +38,7 @@ ${project.build.directory}/extracted-sources/openapi-interfaces ${project.build.directory}/extracted-sources/openapi-impls + etc/spotbugs/exclude.xml diff --git a/pom.xml b/pom.xml index cb190964cfa..ead7510d53e 100644 --- a/pom.xml +++ b/pom.xml @@ -115,6 +115,7 @@ 3.0.0 3.0.1 4.2.0 + 1.11.0 6.0.2 3.0.0-M5 1.1 @@ -495,6 +496,13 @@ ${spotbugs.exclude} true + + + com.h3xstream.findsecbugs + findsecbugs-plugin + ${version.plugin.findsecbugs} + + diff --git a/security/abac/policy-el/etc/spotbugs/exclude.xml b/security/abac/policy-el/etc/spotbugs/exclude.xml new file mode 100644 index 00000000000..dd18476f79a --- /dev/null +++ b/security/abac/policy-el/etc/spotbugs/exclude.xml @@ -0,0 +1,32 @@ + + + + + + + + + + + + + diff --git a/security/abac/policy-el/pom.xml b/security/abac/policy-el/pom.xml index 73ec891a22b..dfacbc07838 100644 --- a/security/abac/policy-el/pom.xml +++ b/security/abac/policy-el/pom.xml @@ -33,6 +33,10 @@ Expression executor support for Expression Language. + + etc/spotbugs/exclude.xml + + io.helidon.security.abac diff --git a/security/providers/http-auth/etc/spotbugs/exclude.xml b/security/providers/http-auth/etc/spotbugs/exclude.xml new file mode 100644 index 00000000000..81f1d7e86e7 --- /dev/null +++ b/security/providers/http-auth/etc/spotbugs/exclude.xml @@ -0,0 +1,39 @@ + + + + + + + + + + + + + + + + + + + + diff --git a/security/providers/http-auth/pom.xml b/security/providers/http-auth/pom.xml index 90f9dc54a87..8da4e53707a 100644 --- a/security/providers/http-auth/pom.xml +++ b/security/providers/http-auth/pom.xml @@ -33,6 +33,10 @@ HTTP basic and digest authentication provider + + etc/spotbugs/exclude.xml + + io.helidon.security.providers diff --git a/webclient/webclient/etc/spotbugs/exclude.xml b/webclient/webclient/etc/spotbugs/exclude.xml new file mode 100644 index 00000000000..e35fb60a2b1 --- /dev/null +++ b/webclient/webclient/etc/spotbugs/exclude.xml @@ -0,0 +1,31 @@ + + + + + + + + + + + + diff --git a/webclient/webclient/pom.xml b/webclient/webclient/pom.xml index d30ea52cb7a..4da3c8f7f8c 100644 --- a/webclient/webclient/pom.xml +++ b/webclient/webclient/pom.xml @@ -30,6 +30,10 @@ helidon-webclient Helidon WebClient + + etc/spotbugs/exclude.xml + + io.helidon.common diff --git a/webserver/static-content/etc/spotbugs/exclude.xml b/webserver/static-content/etc/spotbugs/exclude.xml new file mode 100644 index 00000000000..21f1df67521 --- /dev/null +++ b/webserver/static-content/etc/spotbugs/exclude.xml @@ -0,0 +1,50 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/webserver/static-content/pom.xml b/webserver/static-content/pom.xml index 60ca62b6779..009f8ad88d5 100644 --- a/webserver/static-content/pom.xml +++ b/webserver/static-content/pom.xml @@ -32,6 +32,10 @@ Static content support for Helidon WebServer + + etc/spotbugs/exclude.xml + + io.helidon.common diff --git a/webserver/test-support/etc/spotbugs/exclude.xml b/webserver/test-support/etc/spotbugs/exclude.xml new file mode 100644 index 00000000000..d2c3538385a --- /dev/null +++ b/webserver/test-support/etc/spotbugs/exclude.xml @@ -0,0 +1,38 @@ + + + + + + + + + + + + + + + + + + + diff --git a/webserver/test-support/pom.xml b/webserver/test-support/pom.xml index 15e3aaa03ed..2cece5f2201 100644 --- a/webserver/test-support/pom.xml +++ b/webserver/test-support/pom.xml @@ -29,6 +29,10 @@ helidon-webserver-test-support Helidon WebServer Test Support + + etc/spotbugs/exclude.xml + + io.helidon.webserver diff --git a/webserver/webserver/etc/spotbugs/exclude.xml b/webserver/webserver/etc/spotbugs/exclude.xml index 835d8047965..d760058cd83 100644 --- a/webserver/webserver/etc/spotbugs/exclude.xml +++ b/webserver/webserver/etc/spotbugs/exclude.xml @@ -1,7 +1,7 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +