Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svg inline is altering html and php markup #44

Open
onebitrocket opened this issue Nov 18, 2016 · 1 comment
Open

svg inline is altering html and php markup #44

onebitrocket opened this issue Nov 18, 2016 · 1 comment

Comments

@onebitrocket
Copy link

onebitrocket commented Nov 18, 2016

I am finding that certain html and php markup is being converted when running inline for svgs.
The main issue is converting html and html strings in php variables to self closing tags

Is this due to the svg being converted to short tags?

Is there a way I can prevent this from happening?
I found a useShortTag setting for SVGO
svg/svgo#396

Is there a way to pass additional parameters to a transform plugin, similar to the pretty parameters?
https://www.npmjs.com/package/gulp-svgmin#beautify

I've also looked in to the cheerio load settings
https://github.com/cheeriojs/cheerio#loading

Specifically I think this is to do with concatenated strings and html a tag such as:
'<h1>' . $my_content . '</h1>';
which gets converted to
'<h1>' . $my_content . '';

@onebitrocket onebitrocket changed the title svg inine is affecting other code svg inline is altering html and php markup Nov 18, 2016
@maxkoryukov
Copy link
Contributor

@onebitrocket , looks like formatting in your description is broken...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants