Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

releases don't appear as "clean" #47

Closed
alexeagle opened this issue Oct 1, 2021 · 4 comments
Closed

releases don't appear as "clean" #47

alexeagle opened this issue Oct 1, 2021 · 4 comments
Assignees
@f0rmiga

Comments

@alexeagle
Copy link
Member

install latest GH release, then

% aspect version
Aspect version: v0.0.6 (with local changes)

I fought with this for a couple hours but didn't figure it out. Something about the GH actions environment.
@alexeagle alexeagle reopened this Nov 8, 2021
@f0rmiga
Copy link
Contributor

f0rmiga commented Nov 17, 2021

I'll take this.

@f0rmiga f0rmiga self-assigned this Nov 17, 2021
@alexeagle
Copy link
Member Author

It's super-mystery, I cut several releases in a row using the GH actions with a bunch of extra git commands added, and I don't see how we are failing to determine that the workspace status is pristine.
You could make a fork of this project to experiment on, since I think you'll have to run the real release action. Maybe possible to make it do a dry-run for a PR branch though.

@f0rmiga
Copy link
Contributor

f0rmiga commented Nov 22, 2021

Fixed in #76.

@f0rmiga
Copy link
Contributor

f0rmiga commented Nov 22, 2021

Triggered a release for this in https://github.com/aspect-build/aspect-cli/runs/4292830969 (v0.1.1).

@f0rmiga f0rmiga closed this as completed Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@f0rmiga f0rmiga

Labels
None yet
Projects
Open Source
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexeagle @f0rmiga