Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow canned queries to live in the checked-in rc file #98

Closed
JesseTatasciore opened this issue Jan 6, 2022 · 0 comments · Fixed by #122
Closed

Allow canned queries to live in the checked-in rc file #98

JesseTatasciore opened this issue Jan 6, 2022 · 0 comments · Fixed by #122
Assignees
@JesseTatasciore

Comments

@JesseTatasciore
Copy link
Member

Currently canned queries live within the query code itself. This might do for built in canned queries, but users need to be able to define their own canned queries.

If a built in canned query and a user-defined canned query have the same name, the user defined version should be used
@JesseTatasciore JesseTatasciore added this to the 1.0 milestone Jan 6, 2022
@JesseTatasciore JesseTatasciore self-assigned this Jan 19, 2022
@JesseTatasciore JesseTatasciore linked a pull request Jan 24, 2022 that will close this issue
feat: Allow predefined queries to be specified in aspect configuration #122
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JesseTatasciore JesseTatasciore

Labels
None yet
Projects
Open Source
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Allow predefined queries to be specified in aspect configuration aspect-build/aspect-cli
1 participant
@JesseTatasciore