Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: pre-commit hooks fail on windows #293

Closed
peakschris opened this issue Jun 16, 2024 · 1 comment · Fixed by #311
Closed

[Bug]: pre-commit hooks fail on windows #293

peakschris opened this issue Jun 16, 2024 · 1 comment · Fixed by #311
Labels
bug Something isn't working

Comments

@peakschris
Copy link
Contributor

What happened?

pre-commit install
pre-commit run --all-files

buildifier...............................................................Failed
- hook id: buildifier
- exit code: 1

Executable `/bin/bash` not found

buildifier-lint..........................................................Failed
- hook id: buildifier-lint
- exit code: 1

Executable `/bin/bash` not found

prettier.................................................................Passed

The author of pre-commit suggests to change hooks to use #!/usr/bin/env bash: https://stackoverflow.com/a/71445900

Version

rules_lint latest

How to reproduce

Windows 10
Git for windows
BAZEL_SH set to msys64/bash

Any other information?

No response

@peakschris peakschris added the bug Something isn't working label Jun 16, 2024
@alexeagle
Copy link
Member

It looks like this was fixed in keith/pre-commit-buildifier#21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants