Skip to content
This repository has been archived by the owner on Oct 17, 2018. It is now read-only.

Nugets should not reference facade assemblies as framework dependencies #117

Closed
HenrikFrystykNielsen opened this issue Jan 21, 2016 · 6 comments
Assignees
Milestone

Comments

@HenrikFrystykNielsen
Copy link

Referencing System.IO and other facade assemblies in the nuget metadata fails on .NET 4.5.1 installations. Remove System.IO from the metadata:

<?xml version="1.0" encoding="utf-8"?>
<package xmlns="http://schemas.microsoft.com/packaging/2012/06/nuspec.xsd">
<metadata>
<id>Microsoft.AspNet.DataProtection</id>
<version>1.0.0-rc1-final</version>

<dependencies>

</dependencies>
<frameworkAssemblies>
_<frameworkAssembly assemblyName="System.IO" targetFramework=".NETFramework4.5.1" />_
<frameworkAssembly assemblyName="System.Security" targetFramework=".NETFramework4.5.1" />
<frameworkAssembly assemblyName="System.Xml" targetFramework=".NETFramework4.5.1" />
<frameworkAssembly assemblyName="System.Xml.Linq" targetFramework=".NETFramework4.5.1" />
<frameworkAssembly assemblyName="mscorlib" targetFramework=".NETFramework4.5.1" />
<frameworkAssembly assemblyName="System" targetFramework=".NETFramework4.5.1" />
<frameworkAssembly assemblyName="System.Core" targetFramework=".NETFramework4.5.1" />
<frameworkAssembly assemblyName="Microsoft.CSharp" targetFramework=".NETFramework4.5.1" />
</frameworkAssemblies>
</metadata>
</package>

@blowdart
Copy link
Member

@Tratcher can you take care of this once the general renaming stuff has settled down?

@Tratcher Tratcher self-assigned this Jan 21, 2016
@Tratcher Tratcher added this to the 1.0.0-rc2 milestone Jan 21, 2016
@Tratcher Tratcher added the bug label Jan 21, 2016
@Tratcher Tratcher assigned pakrym and unassigned Tratcher Jan 22, 2016
@muratg muratg assigned davidfowl and unassigned pakrym Mar 21, 2016
@muratg muratg modified the milestones: 1.0.0, 1.0.0-rc2 Mar 21, 2016
@muratg
Copy link

muratg commented Mar 21, 2016

@davidfowl said he has some ideas to make this better in @pakrym's PR above (which was closed without merging.) Moving to 1.0.0 milestone.

@davidfowl please elaborate what you're thinking and we'll assign it to someone.

@davidfowl
Copy link
Member

This is already fixed in the latest packages

@muratg muratg modified the milestones: 1.0.0-rc2, 1.0.0 Mar 21, 2016
@muratg
Copy link

muratg commented Mar 21, 2016

🆒

@muratg muratg closed this as completed Mar 21, 2016
@mattscully
Copy link

@davidfowl Is there a target release date for rc2? I am unable to install package Microsoft.AspNet.WebHooks.Custom.SqlStorage 1.2.0-rc1b which depends on this DataProtection package because of this issue. Or is there a work around?

@mattscully
Copy link

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants