Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] provide return_complex to torch.stft #23

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

GaetanLepage
Copy link
Contributor

As per https://pytorch.org/docs/stable/generated/torch.stft.html, providing return_complex is now mandatory.

@mpariente
Copy link
Contributor

Thank you very much !
What are you building with asteroid-filterbanks ?

@mpariente mpariente merged commit 74a13c6 into asteroid-team:master Dec 2, 2024
@GaetanLepage GaetanLepage deleted the torch-stft branch December 2, 2024 12:01
@GaetanLepage
Copy link
Contributor Author

Thanks for merging the PRs :)
I am not using asteroid-filterbanks myself. I am maintaining several packages in the nixpkgs repository. As the test suite was failing I simply upstreamed the fixes.

@GaetanLepage
Copy link
Contributor Author

Could you consider making a new release ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants