Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruff server does not load new configuration files when they are created #11766

Closed
snowsignal opened this issue Jun 5, 2024 · 2 comments · Fixed by #12253
Closed

ruff server does not load new configuration files when they are created #11766

snowsignal opened this issue Jun 5, 2024 · 2 comments · Fixed by #12253
Assignees
Labels
server Related to the LSP server

Comments

@snowsignal
Copy link
Contributor

If you create a new pyproject.toml / ruff.toml configuration file in your workspace, we reload any existing configuration but do not 'register' the new configuration file.

This has been a known limitation of Index::reload_settings:

/// Reloads relevant existing settings files based on a changed settings file path.
/// This does not currently register new settings files.
@snowsignal snowsignal added the server Related to the LSP server label Jun 5, 2024
@snowsignal snowsignal self-assigned this Jun 7, 2024
@snowsignal snowsignal added this to the Ruff Server: Stable milestone Jun 17, 2024
@dhruvmanila
Copy link
Member

I'm not sure whether this is actually a problem or not because it's suppose to be handled on the client side. The client will send us request on file events (create, change, delete). So, this should work.

@dhruvmanila
Copy link
Member

As seen in the test plan of #12253, I'm creating a new pyproject.toml file in a nested folder and the diagnostics are being refreshed accordingly. At the end, I delete the file and it's refreshed as per the root pyproject.toml file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
server Related to the LSP server
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants