Implement rule for unnecessary import alias

[stinodego]

This is a feature request to implement the following lint from the flake8-tidy-imports package:
https://github.com/adamchainz/flake8-tidy-imports#i250-unnecessary-import-alias

Apparently, it is also an isort rule:
https://pycqa.github.io/isort/docs/configuration/options.html#remove-redundant-aliases

[charliermarsh]

I think we support this as PLC0414, Pylint's "useless-import-alias" rule.

[charliermarsh]

In combination with PLR0402, Pylint's "consider-using-from-import" rule.

[stinodego]

Oh great, that was indeed what I was looking for! Thanks for the help.

Still, I think this raises another question, which is: what to do about rules that are implemented by multiple sources? I'd argue that by enabling the TID lints, I should expect these rules to be enabled.

In any case, I have what I need for now. I'll close this issue - the point I raised above could get its own separate issue if you feel it's merited.

[charliermarsh]

Attaching this to #2186, where we're tracking these kinds of known aliases. I agree that enabling TID should give you this rule, and internally we actually do support rule aliasing, we just haven't figured out all of the details -- there are some tricky cases which make the "right" behavior unclear.