Ruff incorrectly ignores Python files included by negated pattern in .gitignore

[henribru]

Given the following .gitignore:

*
!/src/
!/src/**

and a file src/foo.py, ruff src/ outputs warning: No Python files found under the given path(s). Given that Git includes this file due to the negated pattern overriding the *, this seems like a bug.

This is with 0.1.6 and no Ruff configuration in pyproject.toml.

[charliermarsh]

@BurntSushi -- We use the ignore crate for .gitignore behavior. Would you expect src/foo.py to be included based on the above? (It could definitely be an error on our side and not in the ignore crate, but wanted to check with you first.)

[henribru]

Seems like this might be BurntSushi/ripgrep#1050

[BurntSushi]

It might also be this: BurntSushi/ripgrep#1757 (A fix was merged recently but I believe it has not been released yet.)

But yes, this looks like a bug in the ignore crate to me.

[eli-schwartz]

@BurntSushi -- We use the ignore crate for .gitignore behavior. Would you expect src/foo.py to be included based on the above? (It could definitely be an error on our side and not in the ignore crate, but wanted to check with you first.)

I would expect files that are checked into git with git add --force to be checked, but maybe that is just me? 🤔

[BurntSushi]

The ignore crate only reads .gitignore files. It doesn't actually read the git repository state to determine what's tracked and what isn't. One possible work-around to this is to ensure that .gitignore files are in sync with your repository state.

[charliermarsh]

@BurntSushi - Did that fix go out in the latest version of ignore?

[BurntSushi]

Yeah if the issue here is BurntSushi/ripgrep#1757 then that's in the latest ignore release.

But BurntSushi/ripgrep#1050 remains unfixed.

[charliermarsh]

I actually can't reproduce this on v0.1.6. @henribru - is that the exact pattern and directory structure you were using?

[henribru]

I actually can't reproduce this on v0.1.6. @henribru - is that the exact pattern and directory structure you were using?

Yes. But I discovered something curious: It only seems to reproduce on Windows.