Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init command should warn about conflicted python versions #160

Closed
T-256 opened this issue May 14, 2023 · 1 comment · Fixed by #202
Closed

init command should warn about conflicted python versions #160

T-256 opened this issue May 14, 2023 · 1 comment · Fixed by #202
Labels
enhancement New feature or request

Comments

@T-256
Copy link
Contributor

T-256 commented May 14, 2023

project init

rye init proj --py 3.7.9 --no-readme

pyptoject expected:

requires-python = ">= 3.7"

pyproject actual:

requires-python = ">= 3.8"


I'm aware that we can config that by config.toml or --min-py cli option, but default version behavior when providing toolchain on init, could have improvement.

This also would prevent version conflicts like #82

@T-256
Copy link
Contributor Author

T-256 commented May 14, 2023

possible fix from #82 (comment):

> rye init proj --py 3.7.9 --no-readme
new toolchain has conflict with project's required python ">=3.8" - auto fix it? (y/n) > y

pyproject.toml after auto fix:

requires-python = ">= 3.7"

@T-256 T-256 changed the title requires-python key in pyproject.toml must consider py3.7 toolchain. init command should warn about conflicted python versions May 14, 2023
@mitsuhiko mitsuhiko added the enhancement New feature or request label May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants