You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In PR #5163, @konstinbrought up a concern that the way I was creating the "remaining universe" fork in the case of incomplete markers was either not correct or, perhaps, was doing more than what was needed. I spent some time trying to come up with a packse scenario that demonstrated why it was needed. My first attempt was this:
But as @konstin points out, it doesn't actually exercise the code path in question. I was wrong to think about this in terms of "parent" forks, since those are handled at a different point in the code. So I tried to provoke a scenario where the "remaining universe" fork needed to be constructed by starting from the existing forks, rather than creating its own. I think this requires a double sibling split, but I'm not sure. This is where I stopped:
For now, we decided to move forward with #5163 in its current state since it fixes known bugs and doesn't introduce any known regressions. But this is something we should circle back to.
The text was updated successfully, but these errors were encountered:
I think this is no longer relevant with #5887 merged. Namely, while we are still dealing with incomplete markers, we are doing it more systematically in a way that deals with overlapping markers as well. So this should be fixed (if it was an issue before).
In PR #5163, @konstin brought up a concern that the way I was creating the "remaining universe" fork in the case of incomplete markers was either not correct or, perhaps, was doing more than what was needed. I spent some time trying to come up with a packse scenario that demonstrated why it was needed. My first attempt was this:
But as @konstin points out, it doesn't actually exercise the code path in question. I was wrong to think about this in terms of "parent" forks, since those are handled at a different point in the code. So I tried to provoke a scenario where the "remaining universe" fork needed to be constructed by starting from the existing forks, rather than creating its own. I think this requires a double sibling split, but I'm not sure. This is where I stopped:
For now, we decided to move forward with #5163 in its current state since it fixes known bugs and doesn't introduce any known regressions. But this is something we should circle back to.
The text was updated successfully, but these errors were encountered: