Add PIP_COMPATIBILITY.md to document known deviations from pip
#2244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/pip-compat
branch
from
aea2331 to
881b35b
Compare
|
Still draft, missing one or two things, and need to adjust the README. |
charliermarsh
force-pushed
the
charlie/pip-compat
branch
from
881b35b to
d37985a
Compare
|
Okay, ready for review. The goal here is for this to something we can link to when folks have questions about sub-items in the document. |
konstin
approved these changes
Mar 6, 2024
| ``` | ||
|
|
||
| When uv resolutions differ from `pip` in undesirable ways, it's often a sign that the specifiers | ||
| are too loose, and that the user should consider tightening them. For example, in the case of |
There was a problem hiding this comment.
I'd make this more concrete: Please add >= bounds to your packages.
notatallshaw
reviewed
Mar 6, 2024
PIP_COMPATIBILITY.md
Outdated
| dependency. | ||
|
|
||
| In sum, uv needs to know upfront whether the resolver should accept pre-releases for a given | ||
| package. `pip`, meanwhile, will generally respect pre-release identifiers in transitive |
There was a problem hiding this comment.
FYI, I expanded on this a bit here: #1641 (comment)
It's not important for uv, but certainly anything stronger than "generally" would be wrong, could even be "sometimes".
Anyway, this is great and reads well.
BurntSushi
approved these changes
Mar 6, 2024
charliermarsh
force-pushed
the
charlie/pip-compat
branch
from
d37985a to
a1d2dce
Compare
kdebrab
reviewed
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2023.