Fix/slow response #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icolwell-as
requested changes
Jul 17, 2019
Daniel-Stanek
approved these changes
Jul 18, 2019
rgunjala-as
approved these changes
Jul 19, 2019
icolwell
approved these changes
Jul 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current release of
kvaser_interfacesuffers from very slow performance on reading and writing. The majority of this performance degradation comes from checking the on-bus status through thelinuxcanAPI on every read and write. This PR removes the code to check the on-bus status withlinuxcanevery time, replacing it with a local status variable which is modified when the on-bus state changes. This does not fix the performance problem 100% but is a major improvement (approximately 200% reduction in latency).