Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use an HTML Tidy package thats available via composer #5

Closed
rraub opened this issue Sep 1, 2015 · 12 comments
Closed

Use an HTML Tidy package thats available via composer #5

rraub opened this issue Sep 1, 2015 · 12 comments
Assignees
@idmontie
Labels
enhancement in progress

Comments

@rraub
Copy link
Contributor

rraub commented Sep 1, 2015

It will make this framework more portable.

However no alternatives stand out to me currently.
https://github.com/kesar/HTMLawed might we worth looking into, but thats some of the grosses code I've seen in a while.
@idmontie
Copy link
Contributor

idmontie commented Sep 1, 2015

We can maybe fork it and make it another composer package. Maybe call it Bee_Keeper.

@rraub
Copy link
Contributor Author

rraub commented Sep 1, 2015

WordPress doesn't even do this right: https://codex.wordpress.org/Function_Reference/get_the_excerpt

@idmontie
Copy link
Contributor

We can use PHP_Humanizer once this pull request gets merged in.

@rraub
Copy link
Contributor Author

rraub commented Nov 2, 2015

👍 🐻

@idmontie
Copy link
Contributor

idmontie commented Nov 2, 2015

They merged the branch in, just waiting for a new Release.

@idmontie
Copy link
Contributor

idmontie commented Nov 3, 2015

Waiting for version 1.0.8.

@idmontie
Copy link
Contributor

Version 1.0.9 is out! Starting this now!

@idmontie idmontie self-assigned this Dec 10, 2015
@idmontie idmontie mentioned this issue Dec 10, 2015
Merged
@idmontie
Copy link
Contributor

Ugh, we have to wait for 2.0.0 or a bump above 1.0.9 for PHP 7 compliance.

@idmontie
Copy link
Contributor

idmontie commented Feb 2, 2016

Waiting on coduo/php-humanizer#77

@idmontie
Copy link
Contributor

Will have to completely rewrite the "tidy_service" code.

@idmontie
Copy link
Contributor

Also, no longer waiting on php-humanizer, there is a pre-release that we can use for PHP7: https://github.com/coduo/php-humanizer/releases/tag/2.0.0-beta

@rraub
Copy link
Contributor Author

rraub commented Feb 24, 2016

😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@idmontie idmontie

Labels
enhancement in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rraub @idmontie